Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(741)

Issue 3004: (not quite finished) memoryview implementation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by Antoine Pitrou
Modified:
4 years, 8 months ago
Reviewers:
Benjamin, GvR
Base URL:
http://svn.python.org/view/*checkout*/python/branches/py3k/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : New patch after cosmetic changes suggested by Benjamin & GvR #

Patch Set 3 : Oops, right patch this time #

Patch Set 4 : Fix some small exception bugs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+411 lines, -25 lines) Patch
Lib/test/test_codecs.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_memoryview.py View 1 2 3 2 chunks +190 lines, -2 lines 0 comments Download
Objects/memoryobject.c View 1 2 3 11 chunks +220 lines, -22 lines 0 comments Download

Messages

Total messages: 5
Benjamin
Looks pretty straightforward. Let GvR review though.e http://codereview.appspot.com/3004/diff/1/4 File Lib/test/test_memoryview.py (right): http://codereview.appspot.com/3004/diff/1/4#newcode11 Line 11: class ...
5 years, 8 months ago #1
Antoine Pitrou
http://codereview.appspot.com/3004/diff/1/4 File Lib/test/test_memoryview.py (right): http://codereview.appspot.com/3004/diff/1/4#newcode11 Line 11: class CommonMemoryTests: On 2008/08/19 19:59:52, Benjamin wrote: > ...
5 years, 8 months ago #2
GvR
Sorry, I can't review this. I don't know enough about the PEP 3118 implementation. :-( ...
5 years, 8 months ago #3
Benjamin
A few more comments. I think it's about ready to commit. http://codereview.appspot.com/3004/diff/10/31 File Objects/memoryobject.c (right): ...
5 years, 8 months ago #4
Antoine Pitrou
5 years, 8 months ago #5
http://codereview.appspot.com/3004/diff/10/31
File Objects/memoryobject.c (right):

http://codereview.appspot.com/3004/diff/10/31#newcode606
Line 606: PyErr_SetNone(PyExc_NotImplementedError);
On 2008/08/19 21:19:24, Benjamin wrote:
> I think you want a "return NULL;" after this or it will fall through to the
type
> error. You also might as well add tests for these exceptions.

Yes! Nice catch.

http://codereview.appspot.com/3004/diff/10/31#newcode621
Line 621: Py_buffer *view = &(self->view);
On 2008/08/19 21:19:24, Benjamin wrote:
> It's a bit confusing when you call Py_buffer variables "view" when there's
> another struct called PyMemoryView.

I know, but it's a convention used throughout this file. We can clean it up
later.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5