Ensure juju and lxc are installed

Ensure juju and lxc are installed

To test: make check

To QA:
- Create an lxc or vm without juju installed
- Clone this branch
- Run `make sysdeps`
- Run `make run`

It should install juju, lxc, and dependencies, then prompt you to run again after initializing your juju environments.

https://code.launchpad.net/~makyo/juju-quickstart/ensure-juju-lxc/+merge/196011

(do not edit description out of merge proposal)

[matthew.scott, 2013-11-20 20:40:26]

Please take a look.

[matthew.scott, 2013-11-20 20:42:37]

Please take a look.

[gary.poster, 2013-11-20 21:41:19]

LGTM.  I'm afraid I won't have time for a QA today, but will do it tomorrow if
requested.  Thank you!

https://codereview.appspot.com/29980043/diff/20001/quickstart/tests/helpers.py
File quickstart/tests/helpers.py (right):

https://codereview.appspot.com/29980043/diff/20001/quickstart/tests/helpers.p...
quickstart/tests/helpers.py:88: """Easily use the quickstart.utils.call and
PEP8 style says that the first line should not break.  Maybe this?

Easily use `call` and `sudo_call` from quickstart.utils.

[matthew.scott, 2013-11-20 21:43:54]

Please take a look.

https://codereview.appspot.com/29980043/diff/20001/quickstart/tests/helpers.py
File quickstart/tests/helpers.py (right):

https://codereview.appspot.com/29980043/diff/20001/quickstart/tests/helpers.p...
quickstart/tests/helpers.py:88: """Easily use the quickstart.utils.call and
On 2013/11/20 21:41:20, gary.poster wrote:
> PEP8 style says that the first line should not break.  Maybe this?
> 
> Easily use `call` and `sudo_call` from quickstart.utils.

Reverting, left over from my previous solution.  Good to know, though!

[matthew.scott, 2013-11-20 21:47:24]

On 2013/11/20 21:46:39, matthew.scott wrote:

Thanks, RV.  That was supposed to be a reply to Gary - the comment was old,
reverted.

[frankban, 2013-11-21 12:02:03]

Nice branch Matthew, thank you!
LGTM with changes (see below).
Will QA later.

https://codereview.appspot.com/29980043/diff/40001/quickstart/app.py
File quickstart/app.py (right):

https://codereview.appspot.com/29980043/diff/40001/quickstart/app.py#newcode60
quickstart/app.py:60: cmds = [
ISTM that this is a good place to inform the user about what's happening, e.g.:
'juju is not installed', 'sudo privileges required to install juju'. It could be
nice to give an idea about why we need sudo.

https://codereview.appspot.com/29980043/diff/40001/quickstart/app.py#newcode66
quickstart/app.py:66: cmd.insert(0, 'sudo')
You can either add sudo in the cmds above (and make cmds a list of tuples) or
just "retcode, _, error = utils.call('sudo', *cmd)" below (and make cmds a list
of tuples :-). <shrug>

https://codereview.appspot.com/29980043/diff/40001/quickstart/app.py#newcode73
quickstart/app.py:73: raise ProgramExit('Juju is now installed; please run `juju
init` and '
I am not sure about exiting with an error here.
What if the user has a juju home properly set up but juju is not installed? This
is not uncommon, e.g. he removed the package, or he is working in a lxc sharing
his home directory. Moreover this code is never reached if the envs.yaml is not
properly set up, so we are just preventing users with a configured juju home to
proceed. I think we should just continue with the normal execution here: in the
future we will guide the user setting up the environment.

https://codereview.appspot.com/29980043/diff/40001/quickstart/manage.py
File quickstart/manage.py (right):

https://codereview.appspot.com/29980043/diff/40001/quickstart/manage.py#newco...
quickstart/manage.py:221: print('ensuring juju and lxc are installed')
What do you think about making this a logging.debug call? I am not sure about
how much this is informative after the first run.

[bac, 2013-11-21 18:43:36]

Changes made.  Having to re-propose to a new merge proposal before landing.

https://codereview.appspot.com/29980043/diff/40001/quickstart/app.py
File quickstart/app.py (right):

https://codereview.appspot.com/29980043/diff/40001/quickstart/app.py#newcode60
quickstart/app.py:60: cmds = [
On 2013/11/21 12:02:03, frankban wrote:
> ISTM that this is a good place to inform the user about what's happening,
e.g.:
> 'juju is not installed', 'sudo privileges required to install juju'. It could
be
> nice to give an idea about why we need sudo.

Done.

https://codereview.appspot.com/29980043/diff/40001/quickstart/app.py#newcode66
quickstart/app.py:66: cmd.insert(0, 'sudo')
On 2013/11/21 12:02:03, frankban wrote:
> You can either add sudo in the cmds above (and make cmds a list of tuples) or
> just "retcode, _, error = utils.call('sudo', *cmd)" below (and make cmds a
list
> of tuples :-). <shrug>
> 

Done.

https://codereview.appspot.com/29980043/diff/40001/quickstart/app.py#newcode73
quickstart/app.py:73: raise ProgramExit('Juju is now installed; please run `juju
init` and '
On 2013/11/21 12:02:03, frankban wrote:
> I am not sure about exiting with an error here.
> What if the user has a juju home properly set up but juju is not installed?
This
> is not uncommon, e.g. he removed the package, or he is working in a lxc
sharing
> his home directory. Moreover this code is never reached if the envs.yaml is
not
> properly set up, so we are just preventing users with a configured juju home
to
> proceed. I think we should just continue with the normal execution here: in
the
> future we will guide the user setting up the environment.

Done.

https://codereview.appspot.com/29980043/diff/40001/quickstart/manage.py
File quickstart/manage.py (right):

https://codereview.appspot.com/29980043/diff/40001/quickstart/manage.py#newco...
quickstart/manage.py:221: print('ensuring juju and lxc are installed')
On 2013/11/21 12:02:03, frankban wrote:
> What do you think about making this a logging.debug call? I am not sure about
> how much this is informative after the first run.

Done.