Issue 2996041: Use list binding for gadget rewriters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2996041: Use list binding for gadget rewriters

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by zhoresh

Modified:
15 years, 1 month ago

Reviewers:
johnfargo, dev-remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk

Visibility:
Public.

Description

Gadget rewriters order is important so it should still be list instead of set. The internal binding though can still be multibinding since it is implemented using ordered set. See SHINDIG-1456 for more details

Patch Set 1 #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+26 lines, -14 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/GadgetRewritersProvider.java	View	2 chunks	+5 lines, -4 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java	View	3 chunks	+3 lines, -2 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewriteModule.java	View	3 chunks	+14 lines, -3 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriterTest.java	View	3 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

zhoresh

Please ignore RenderingGadgetRewriter changes, it belongs to other change.

15 years, 1 month ago (2010-11-09 00:16:38 UTC) #2

johnfargo

LGTM Except RenderingGadgetRewriter JsUri changes :) On 2010/11/09 00:16:38, zhoresh wrote: > Please ignore RenderingGadgetRewriter ...

15 years, 1 month ago (2010-11-09 00:19:50 UTC) #3

2 Files only, submitted r1032792

Expand All Messages | Collapse All Messages