Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3607)

Issue 299530044: engine: Use annotations/en.xml from unocode.org but not emoji-list.html (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by fujiwara
Modified:
7 years, 11 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

engine: Use annotations/en.xml from unocode.org but not emoji-list.html Downloading emoji-list would cause a different build by build site. Now save annotations/en.xml from unicode.org and get emoji.json from Emoji One. en.xml is used for Unicode annotations and emoji.json is used for aliases_ascii, e.g. ":)", and category, e.g. "people". BUG=https://github.com/ibus/ibus/issues/1865 R=Shawn.P.Huang@gmail.com Committed: 0ee1896a2b3e75494f8f9fd9d04c27436f0877b8

Patch Set 1 #

Patch Set 2 : Typo in configure.ac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1611 lines, -161 lines) Patch
A COPYING.unicode View 1 chunk +52 lines, -0 lines 0 comments Download
M Makefile.am View 1 chunk +1 line, -0 lines 0 comments Download
M configure.ac View 1 3 chunks +12 lines, -2 lines 0 comments Download
M data/Makefile.am View 2 chunks +3 lines, -2 lines 0 comments Download
A + data/annotations/Makefile.am View 2 chunks +4 lines, -4 lines 0 comments Download
A data/annotations/en.xml View 1 chunk +1042 lines, -0 lines 0 comments Download
M ibus.spec.in View 4 chunks +14 lines, -0 lines 0 comments Download
M src/Makefile.am View 2 chunks +5 lines, -26 lines 0 comments Download
M src/emoji-parser.c View 2 chunks +478 lines, -127 lines 0 comments Download

Messages

Total messages: 4
fujiwara
7 years, 11 months ago (2016-07-05 05:28:17 UTC) #1
Peng
On 2016/07/05 05:28:17, fujiwara wrote: LGTM. And I imagine using vala or python may make ...
7 years, 11 months ago (2016-07-05 12:45:38 UTC) #2
fujiwara
On 2016/07/05 12:45:38, Peng wrote: > On 2016/07/05 05:28:17, fujiwara wrote: > > LGTM. And ...
7 years, 11 months ago (2016-07-06 10:49:24 UTC) #3
fujiwara
7 years, 11 months ago (2016-07-07 03:47:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0ee1896a2b3e75494f8f9fd9d04c27436f0877b8 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b