Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(281)

Issue 2988042: Implement JS data fetch through GadgetHandler

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by zhoresh
Modified:
15 years, 4 months ago
Reviewers:
johnfargo, dev-remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Add one more test #

Total comments: 15

Patch Set 3 : Update according to Fargo comments #

Messages

Total messages: 7
zhoresh
15 years, 4 months ago (2010-11-09 23:43:25 UTC) #1
zhoresh
Add one more test
15 years, 4 months ago (2010-11-10 17:41:15 UTC) #2
johnfargo
http://codereview.appspot.com/2988042/diff/7001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java (right): http://codereview.appspot.com/2988042/diff/7001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java#newcode218 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java:218: public boolean getIgnoreCahce(); s/getIgnoreCahce/getIgnoreCache/ http://codereview.appspot.com/2988042/diff/7001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java (right): http://codereview.appspot.com/2988042/diff/7001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java#newcode206 ...
15 years, 4 months ago (2010-11-11 01:14:32 UTC) #3
zhoresh
http://codereview.appspot.com/2988042/diff/7001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java (right): http://codereview.appspot.com/2988042/diff/7001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java#newcode218 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java:218: public boolean getIgnoreCahce(); On 2010/11/11 01:14:32, johnfargo wrote: > ...
15 years, 4 months ago (2010-11-11 19:03:53 UTC) #4
zhoresh
Update according to Fargo comments
15 years, 4 months ago (2010-11-11 19:04:28 UTC) #5
johnfargo
LGTM On Thu, Nov 11, 2010 at 11:04 AM, <zhoresh@gmail.com> wrote: > Update according to ...
15 years, 4 months ago (2010-11-12 01:30:58 UTC) #6
zhoresh
15 years, 4 months ago (2010-11-12 02:06:34 UTC) #7
On 2010/11/12 01:30:58, johnfargo wrote:
> LGTM
> 

Thanks! committed at r1034245
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b