Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(670)

Issue 298580043: engine: Add emoji-list.html (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by fujiwara
Modified:
7 years, 10 months ago
Reviewers:
shawn.p.huang
CC:
shawn.p.huang_gmail.com, ebassi_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

engine: Add emoji-list.html Now we copied http://unicode.org/emoji/charts/emoji-list.html to http://ibus.github.io/files/ibus/emoji-list.html and download the file in the build time. We don't save emoji-list.html in the tarball because the file size is more than 5MB. We always don't get the latest emoji-list.html to avoid the build error. BUG=https://github.com/ibus/ibus/pull/1864 R=shawn.p.huang@gmail.com Committed: 0ed644cd2b6c1d15bdba0d1c6d45d162b9b34806

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M src/Makefile.am View 3 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 3
fujiwara
7 years, 10 months ago (2016-06-22 08:35:26 UTC) #1
shawn.p.huang_gmail.com
Lgtm <takao.fujiwara1@gmail.com>于2016年6月22日周三 04:35写道: > Reviewers: shawn.p.huang_gmail.com, > > Description: > engine: Add emoji-list.html > > ...
7 years, 10 months ago (2016-06-22 11:42:05 UTC) #2
fujiwara
7 years, 10 months ago (2016-06-23 02:52:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0ed644cd2b6c1d15bdba0d1c6d45d162b9b34806 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b