ui/gtk3: Fix panel CSS format for GTK 3.20

ui/gtk3: Fix panel CSS format for GTK 3.20

CSS node names have been changed since GTK 3.20 and the font size and
widget color no longer work with the previous node names.

BUG=https://github.com/ibus/ibus/issues/1856

Committed: a598ae29223d1ca25e76bf7d7de9703f63ea337e

[Peng, 2016-06-02 11:23:05]

https://codereview.appspot.com/297380043/diff/1/ui/gtk3/candidatearea.vala
File ui/gtk3/candidatearea.vala (right):

https://codereview.appspot.com/297380043/diff/1/ui/gtk3/candidatearea.vala#ne...
ui/gtk3/candidatearea.vala:34: private bool m_use_latest_css_format =
const bool?

why not compare version directly? for example:

m_use_lastest_css_format = Gtk.MAJOR_VERSION >= 30 && Gtk.MINOR_VERSION >= 20;

https://codereview.appspot.com/297380043/diff/1/ui/gtk3/candidatearea.vala#ne...
ui/gtk3/candidatearea.vala:123: if (m_use_latest_css_format) {
How about change the code to?

const string name = m_use_latest_css_format ? "..." : 'background-color";
context.get(...);
pango_attr = ...;

https://codereview.appspot.com/297380043/diff/1/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/297380043/diff/1/ui/gtk3/panel.vala#newcode547
ui/gtk3/panel.vala:547: if
(Panel.compare_versions("%d.%d.%d".printf(Gtk.MAJOR_VERSION,
Same

[fujiwara, 2016-06-03 04:57:27]

https://codereview.appspot.com/297380043/diff/1/ui/gtk3/candidatearea.vala
File ui/gtk3/candidatearea.vala (right):

https://codereview.appspot.com/297380043/diff/1/ui/gtk3/candidatearea.vala#ne...
ui/gtk3/candidatearea.vala:34: private bool m_use_latest_css_format =
On 2016/06/02 11:23:05, Peng wrote:
> const bool?
> 
> why not compare version directly? for example:
> 
> m_use_lastest_css_format = Gtk.MAJOR_VERSION >= 30 && Gtk.MINOR_VERSION >= 20;

Done.

https://codereview.appspot.com/297380043/diff/1/ui/gtk3/candidatearea.vala#ne...
ui/gtk3/candidatearea.vala:123: if (m_use_latest_css_format) {
On 2016/06/02 11:23:05, Peng wrote:
> How about change the code to?
> 
> const string name = m_use_latest_css_format ? "..." : 'background-color";
> context.get(...);
> pango_attr = ...;

Done.

https://codereview.appspot.com/297380043/diff/1/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/297380043/diff/1/ui/gtk3/panel.vala#newcode547
ui/gtk3/panel.vala:547: if
(Panel.compare_versions("%d.%d.%d".printf(Gtk.MAJOR_VERSION,
On 2016/06/02 11:23:05, Peng wrote:
> Same

Done.

[Peng, 2016-06-03 09:58:38]

lgtm

[fujiwara, 2016-06-03 10:44:48]

Committed patchset #2 (id:20001) manually as
a598ae29223d1ca25e76bf7d7de9703f63ea337e (presubmit successful).