Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(86)

Issue 297380043: ui/gtk3: Fix panel CSS format for GTK 3.20 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by fujiwara
Modified:
10 years ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

ui/gtk3: Fix panel CSS format for GTK 3.20 CSS node names have been changed since GTK 3.20 and the font size and widget color no longer work with the previous node names. BUG=https://github.com/ibus/ibus/issues/1856 Committed: a598ae29223d1ca25e76bf7d7de9703f63ea337e

Patch Set 1 #

Total comments: 6

Patch Set 2 : Updated with the message #2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -7 lines) Patch
M ui/gtk3/candidatearea.vala View 1 4 chunks +13 lines, -3 lines 0 comments Download
M ui/gtk3/handle.vala View 1 3 chunks +8 lines, -2 lines 0 comments Download
M ui/gtk3/panel.vala View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5
fujiwara
10 years, 1 month ago (2016-05-27 10:15:45 UTC) #1
Peng
https://codereview.appspot.com/297380043/diff/1/ui/gtk3/candidatearea.vala File ui/gtk3/candidatearea.vala (right): https://codereview.appspot.com/297380043/diff/1/ui/gtk3/candidatearea.vala#newcode34 ui/gtk3/candidatearea.vala:34: private bool m_use_latest_css_format = const bool? why not compare ...
10 years ago (2016-06-02 11:23:05 UTC) #2
fujiwara
https://codereview.appspot.com/297380043/diff/1/ui/gtk3/candidatearea.vala File ui/gtk3/candidatearea.vala (right): https://codereview.appspot.com/297380043/diff/1/ui/gtk3/candidatearea.vala#newcode34 ui/gtk3/candidatearea.vala:34: private bool m_use_latest_css_format = On 2016/06/02 11:23:05, Peng wrote: ...
10 years ago (2016-06-03 04:57:27 UTC) #3
Peng
lgtm
10 years ago (2016-06-03 09:58:38 UTC) #4
fujiwara
10 years ago (2016-06-03 10:44:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a598ae29223d1ca25e76bf7d7de9703f63ea337e (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b