Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(161)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 297350043: Fixed a bug in OSX. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by scudette
Modified:
9 years, 11 months ago
Reviewers:
Jordi
CC:
adamsh
Base URL:
https://github.com/google/rekall.git@master
Visibility:
Public.

Description

Fixed a bug in OSX. Also updated more windows plugins to typed output. R=parki.san@gmail.com Committed: 59dc2bae9f12bcae16d5c153f810b575e46062eb

Patch Set 1 #

Patch Set 2 : #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -106 lines) Patch
M rekall-core/rekall/obj.py View 1 1 chunk +1 line, -1 line 0 comments Download
M rekall-core/rekall/plugins/common/search.py View 1 1 chunk +2 lines, -0 lines 2 comments Download
M rekall-core/rekall/plugins/overlays/darwin/darwin.py View 1 1 chunk +2 lines, -2 lines 1 comment Download
M rekall-core/rekall/plugins/windows/handles.py View 1 3 chunks +26 lines, -47 lines 0 comments Download
M rekall-core/rekall/plugins/windows/modules.py View 1 7 chunks +52 lines, -54 lines 2 comments Download
M tools/installers/winbuild.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/pmem/pmem.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
scudette
9 years, 11 months ago (2016-05-23 22:29:02 UTC) #1
Jordi
LGTM https://codereview.appspot.com/297350043/diff/20001/rekall-core/rekall/plugins/common/search.py File rekall-core/rekall/plugins/common/search.py (right): https://codereview.appspot.com/297350043/diff/20001/rekall-core/rekall/plugins/common/search.py#newcode169 rekall-core/rekall/plugins/common/search.py:169: self.session.logging.debug("Producing %s from producer %r", Do we still ...
9 years, 11 months ago (2016-05-23 22:36:58 UTC) #2
scudette
https://codereview.appspot.com/297350043/diff/20001/rekall-core/rekall/plugins/common/search.py File rekall-core/rekall/plugins/common/search.py (right): https://codereview.appspot.com/297350043/diff/20001/rekall-core/rekall/plugins/common/search.py#newcode169 rekall-core/rekall/plugins/common/search.py:169: self.session.logging.debug("Producing %s from producer %r", On 2016/05/23 22:36:57, Jordi ...
9 years, 11 months ago (2016-05-23 23:12:42 UTC) #3
scudette
9 years, 11 months ago (2016-05-24 00:08:38 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
59dc2bae9f12bcae16d5c153f810b575e46062eb (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b