Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1590)

Issue 297340043: Add halfopenvertical to script.scm

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by Carl
Modified:
3 years, 7 months ago
Reviewers:
thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add halfopenvertical to script.scm

Patch Set 1 #

Patch Set 2 : Fix documentation error. Now passes make and make doc on my machine #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M Documentation/included/script-chart.ly View 1 1 chunk +1 line, -0 lines 0 comments Download
A input/regression/halfopenvertical.ly View 1 chunk +19 lines, -0 lines 0 comments Download
M scm/script.scm View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5
thomasmorley651
Fine with me for script.scm Not sure about the regtest, though. Testing (new) articulations with ...
3 years, 8 months ago (2016-05-23 22:21:01 UTC) #1
Carl
It seems to me that if we want to make this kind of a regtest ...
3 years, 8 months ago (2016-05-24 23:57:38 UTC) #2
Carl
On 2016/05/24 23:57:38, Carl wrote: > > The challenge is that some of the feta ...
3 years, 8 months ago (2016-05-25 00:03:44 UTC) #3
Carl
Fix documentation error. Now passes make and make doc on my machine
3 years, 7 months ago (2016-06-12 13:34:37 UTC) #4
Carl
3 years, 7 months ago (2016-06-12 13:40:27 UTC) #5
The error that was identified in make doc actually resolves the problem Harm was
concerned about. If a script is added to scripts.scm as an articulation, and
that articulation is not added to Documentation/included/script-chart.ly, then
make doc fails.

So I think we are covered for some automated method of verifying that all
articulations listed in scripts.scm is in fact tested by the build process
(although not in the regression tests).

Thanks,

Carl
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b