Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(259)

Issue 297250043: Add mechanism to trim HTTP response headers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by nickie
Modified:
8 years, 10 months ago
Reviewers:
nednguyen
Base URL:
https://chromium.googlesource.com/external/github.com/chromium/web-page-replay.git@master
Visibility:
Public.

Description

Add mechanism to trim HTTP response headers The main motivation for this is to drop headers like "content-security-policy", which are known to cause problems with script injections in sites with strict policies. R=nednguyen@google.com BUG=#72

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -5 lines) Patch
M httparchive.py View 6 chunks +41 lines, -4 lines 0 comments Download
M httparchive_test.py View 1 2 chunks +43 lines, -1 line 0 comments Download

Messages

Total messages: 6
nickie
8 years, 10 months ago (2016-05-10 17:04:36 UTC) #1
nickie
This patch installs the mechanism for trimming response headers and actually trims "content-security-policy". This is ...
8 years, 10 months ago (2016-05-10 17:09:33 UTC) #2
nednguyen
Can you add test coverage?
8 years, 10 months ago (2016-05-11 21:52:44 UTC) #3
nickie
On 2016/05/11 21:52:44, nednguyen wrote: > Can you add test coverage? I added a test ...
8 years, 10 months ago (2016-05-12 14:25:13 UTC) #4
nednguyen
lgtm
8 years, 10 months ago (2016-05-13 17:14:32 UTC) #5
nednguyen
8 years, 10 months ago (2016-05-13 17:16:49 UTC) #6
On 2016/05/13 17:14:32, nednguyen wrote:
> lgtm

Thanks for your work, this is landed in
https://github.com/chromium/web-page-replay/commit/d23e5a88d82d1e1f6ce759f701...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b