Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(63)

Issue 296600043: Make \header blocks tangible in Scheme

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 2 months ago by dak
Modified:
3 years, 2 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Make \header blocks tangible in Scheme This treats Guile modules and \header blocks as more or less equivalent. Since \header blocks also contain module imports that might not concur with those at the place of use, any use of a module in place of a \header merely copies the values of the module variables. Consists of the commits: Admit \header-like expression into \score Admit \header-like expressions in \header Admit \header-like expressions at top levels \header-like expressions are allowed at \book, \bookpart, and top level. Allow \header blocks in expressions This allows creating modules for further programmatic manipulation.

Patch Set 1 #

Patch Set 2 : Changes entry, identifiers regtest #

Total comments: 3

Patch Set 3 : Use \markupId and \stringId in identifiers regtest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -11 lines) Patch
M Documentation/changes.tely View 1 1 chunk +11 lines, -0 lines 0 comments Download
M input/regression/identifiers.ly View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M lily/parser.yy View 9 chunks +52 lines, -7 lines 0 comments Download

Messages

Total messages: 11
thomasmorley651
Can't review the code. From description: very nice. Though, I'm not sure to which grade ...
3 years, 2 months ago (2016-06-28 17:09:04 UTC) #1
dak
On 2016/06/28 17:09:04, thomasmorley651 wrote: > Can't review the code. > From description: very nice. ...
3 years, 2 months ago (2016-06-28 17:29:19 UTC) #2
pkx166h
On 2016/06/28 17:29:19, dak wrote: > On 2016/06/28 17:09:04, thomasmorley651 wrote: > > Can't review ...
3 years, 2 months ago (2016-06-28 18:16:05 UTC) #3
dak
On 2016/06/28 18:16:05, pkx166h wrote: > On 2016/06/28 17:29:19, dak wrote: > > On 2016/06/28 ...
3 years, 2 months ago (2016-06-28 18:26:44 UTC) #4
thomasmorley651
On 2016/06/28 17:29:19, dak wrote: > On 2016/06/28 17:09:04, thomasmorley651 wrote: > > Can't review ...
3 years, 2 months ago (2016-06-28 20:10:00 UTC) #5
dak
Changes entry, identifiers regtest
3 years, 2 months ago (2016-06-29 16:58:47 UTC) #6
thomasmorley651
regtest and changes LGTM From experimenting with it, changes in parser are great. A remark, ...
3 years, 2 months ago (2016-06-29 21:56:23 UTC) #7
Dan Eble
https://codereview.appspot.com/296600043/diff/20001/input/regression/identifiers.ly File input/regression/identifiers.ly (right): https://codereview.appspot.com/296600043/diff/20001/input/regression/identifiers.ly#newcode11 input/regression/identifiers.ly:11: scoreHeaderId = \header { piece = "Piece" } This ...
3 years, 2 months ago (2016-06-30 01:38:08 UTC) #8
dak
https://codereview.appspot.com/296600043/diff/20001/input/regression/identifiers.ly File input/regression/identifiers.ly (right): https://codereview.appspot.com/296600043/diff/20001/input/regression/identifiers.ly#newcode14 input/regression/identifiers.ly:14: markupId = \markup { hoi } On 2016/06/29 21:56:23, ...
3 years, 2 months ago (2016-06-30 05:03:24 UTC) #9
dak
Use \markupId and \stringId in identifiers regtest
3 years, 2 months ago (2016-06-30 10:27:46 UTC) #10
thomasmorley651
3 years, 2 months ago (2016-07-02 08:59:56 UTC) #11
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b