Bug 1281020 - Add HKDF tests for SHA-384

Bug 1281020 - Add HKDF tests for SHA-384

[ekr-rietveld, 2016-06-21 17:13:19]

https://codereview.appspot.com/295630043/diff/1/external_tests/ssl_gtest/tls_...
File external_tests/ssl_gtest/tls_hkdf_unittest.cc (right):

https://codereview.appspot.com/295630043/diff/1/external_tests/ssl_gtest/tls_...
external_tests/ssl_gtest/tls_hkdf_unittest.cc:231: }
Would parametrizing these make more sense?

Also, can you validate the existing test vectors?

[ttaubert, 2016-06-21 19:10:28]

On 2016/06/21 17:13:19, ekr-webrtc wrote:
>
https://codereview.appspot.com/295630043/diff/1/external_tests/ssl_gtest/tls_...
> external_tests/ssl_gtest/tls_hkdf_unittest.cc:231: }
> Would parametrizing these make more sense?

By what exactly do you suggest to parametrize it? If we take e.g. the hash
function as a parameter then we'd have to pick the corresponding test vector
somehow, I think this might not end up as clean as it is now.

> Also, can you validate the existing test vectors?

Done, that's what I started with in order to write the script I used to generate
the SHA-384 vectors.

[ekr-rietveld, 2016-06-21 23:23:08]

LGTM

https://codereview.appspot.com/295630043/diff/20001/external_tests/ssl_gtest/...
File external_tests/ssl_gtest/tls_hkdf_unittest.cc (right):

https://codereview.appspot.com/295630043/diff/20001/external_tests/ssl_gtest/...
external_tests/ssl_gtest/tls_hkdf_unittest.cc:94: ,
slot_(PK11_GetInternalSlot())
Our convention in this code is that commas trail

https://codereview.appspot.com/295630043/diff/20001/external_tests/ssl_gtest/...
external_tests/ssl_gtest/tls_hkdf_unittest.cc:106: EXPECT_TRUE(false);
You could make a table for this.

https://codereview.appspot.com/295630043/diff/20001/external_tests/ssl_gtest/...
external_tests/ssl_gtest/tls_hkdf_unittest.cc:159: uint8_t hash_length_;
size_t please.

[ttaubert, 2016-06-22 10:50:16]

https://codereview.appspot.com/295630043/diff/20001/external_tests/ssl_gtest/...
File external_tests/ssl_gtest/tls_hkdf_unittest.cc (right):

https://codereview.appspot.com/295630043/diff/20001/external_tests/ssl_gtest/...
external_tests/ssl_gtest/tls_hkdf_unittest.cc:94: ,
slot_(PK11_GetInternalSlot())
On 2016/06/21 23:23:08, ekr-webrtc wrote:
> Our convention in this code is that commas trail

Done.

https://codereview.appspot.com/295630043/diff/20001/external_tests/ssl_gtest/...
external_tests/ssl_gtest/tls_hkdf_unittest.cc:106: EXPECT_TRUE(false);
On 2016/06/21 23:23:08, ekr-webrtc wrote:
> You could make a table for this.
> 

Done.

https://codereview.appspot.com/295630043/diff/20001/external_tests/ssl_gtest/...
external_tests/ssl_gtest/tls_hkdf_unittest.cc:159: uint8_t hash_length_;
On 2016/06/21 23:23:08, ekr-webrtc wrote:
> size_t please.

Done.