Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2802)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 295610043: engine: Implement Emoji typing with XKB engines (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by fujiwara
Modified:
8 years ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

engine: Implement Emoji typing with XKB engines Now Ctrl+Shift+e can convert an Emoji annotation to the Emoji characters likes Ctrl+Shift+u. The annotations are described as "Keywords" in the Unicode Emoji Data: http://www.unicode.org/emoji/charts/emoji-list.html 'emoji-parser' compiles 'emoji-list.html' and generates 'emoji.dict' Committed: 160d3c975af91eea6b8271b757be769b8ceef98d

Patch Set 1 #

Total comments: 10

Patch Set 2 : Updated with comment #3. #

Patch Set 3 : Trim spaces. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+890 lines, -41 lines) Patch
M configure.ac View 1 2 chunks +16 lines, -0 lines 0 comments Download
M src/Makefile.am View 1 1 chunk +31 lines, -0 lines 0 comments Download
A src/emoji-parser.c View 1 2 1 chunk +217 lines, -0 lines 0 comments Download
M src/ibusenginesimple.c View 1 25 chunks +406 lines, -37 lines 0 comments Download
M src/ibusutil.h View 2 chunks +29 lines, -2 lines 0 comments Download
M src/ibusutil.c View 1 4 chunks +191 lines, -2 lines 0 comments Download

Messages

Total messages: 5
fujiwara
Since emoji-list.html is too large, please download it with 'wget http://www.unicode.org/emoji/charts/emoji-list.html'.
8 years ago (2016-06-17 11:05:00 UTC) #1
Peng
On 2016/06/17 11:05:00, fujiwara wrote: > Since emoji-list.html is too large, please download it with ...
8 years ago (2016-06-19 16:47:38 UTC) #2
Peng
Some nits https://codereview.appspot.com/295610043/diff/1/configure.ac File configure.ac (right): https://codereview.appspot.com/295610043/diff/1/configure.ac#newcode605 configure.ac:605: [Do not build dict files]), why not ...
8 years ago (2016-06-19 16:47:53 UTC) #3
fujiwara
https://codereview.appspot.com/295610043/diff/1/configure.ac File configure.ac (right): https://codereview.appspot.com/295610043/diff/1/configure.ac#newcode605 configure.ac:605: [Do not build dict files]), On 2016/06/19 16:47:53, Peng ...
8 years ago (2016-06-20 07:49:14 UTC) #4
fujiwara
8 years ago (2016-06-21 09:10:30 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
160d3c975af91eea6b8271b757be769b8ceef98d (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b