Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 295340043: Install a DBus service file (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 1 month ago by fujiwara
Modified:
8 years, 1 month ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com, tiagomatos_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Install a DBus service file With the transition to user scoped DBus sessions (vs. login sessions) there's a need to start ibus-daemon via DBus activation so that the process gets properly tracked and disposed of when the login session ends. Otherwise the ibus-daemon process lingers on and keeps the whole login session up. We already connect and own a well known name on DBus. The remaining missing piece is the DBus service file which we introduce here. BUG=https://github.com/ibus/ibus/pull/1853 R=Shawn.P.Huang@gmail.com Committed: 84c18f1d382548c52138822a11473d2dac79e485

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M bus/Makefile.am View 1 chunk +11 lines, -0 lines 0 comments Download
A bus/org.freedesktop.IBus.service.in View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3
fujiwara
8 years, 1 month ago (2016-05-24 07:29:48 UTC) #1
Peng
On 2016/05/24 07:29:48, fujiwara wrote: lgtm
8 years, 1 month ago (2016-05-24 07:45:21 UTC) #2
fujiwara
8 years, 1 month ago (2016-05-25 02:21:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
84c18f1d382548c52138822a11473d2dac79e485 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b