Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(83)

Issue 294650043: Move translator initializations to X::boot ()

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 3 months ago by dak
Modified:
3 years, 3 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Move translator initializations to X::boot () This reorganization of the C++ translator initializations leads to more predictable initialization order and makes the initializations have access to private members of the class. This is a precondition for more restrictive access control, helping to pin down accidental references to members of the wrong class. Also contains commit: Rewrite of new translator initializations This was done by running the following Bash script: git grep '^ADD_TRANSLATOR (' lily|sed 's/^\([^:]*\):ADD_TRANSLATOR ( *\([a-zA-Z_]\+\),.*$/\1 \2/' | while read file translator do lines="$(git grep -h '^\(ADD_ACKNOWLEDGER\|ADD_END_ACKNOWLEDGER\|IMPLEMENT_TRANSLATOR_LISTENER\) ('$translator, $file)" sed -i "$(echo "$lines"|sed 's+^..*$+/&/d+')" $file sed -i "/^ADD_TRANSLATOR ($translator,/i\\ void\\ $translator::boot ()\\ {\\ $(echo "$lines"|sed 's/IMPLEMENT_TRANSLATOR_LISTENER/ADD_LISTENER/;s/^./ &/;s/$/\\/') }\\ " $file done

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+976 lines, -308 lines) Patch
M lily/accidental-engraver.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M lily/ambitus-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/arpeggio-engraver.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M lily/auto-beam-engraver.cc View 4 chunks +22 lines, -12 lines 0 comments Download
M lily/axis-group-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/balloon-engraver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/bar-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/bar-number-engraver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/beam-collision-engraver.cc View 1 chunk +14 lines, -9 lines 0 comments Download
M lily/beam-engraver.cc View 4 chunks +16 lines, -6 lines 0 comments Download
M lily/beam-performer.cc View 2 chunks +6 lines, -1 line 0 comments Download
M lily/bend-engraver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/break-align-engraver.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M lily/breathing-sign-engraver.cc View 2 chunks +6 lines, -1 line 0 comments Download
M lily/chord-name-engraver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/chord-tremolo-engraver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/clef-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/cluster-engraver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/collision-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/completion-note-heads-engraver.cc View 2 chunks +6 lines, -1 line 0 comments Download
M lily/completion-rest-engraver.cc View 2 chunks +6 lines, -1 line 0 comments Download
M lily/concurrent-hairpin-engraver.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M lily/control-track-performer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M lily/cue-clef-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/custos-engraver.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M lily/default-bar-line-engraver.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M lily/dot-column-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/dots-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/double-percent-repeat-engraver.cc View 2 chunks +6 lines, -1 line 0 comments Download
M lily/drum-note-engraver.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M lily/drum-note-performer.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/dynamic-align-engraver.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M lily/dynamic-engraver.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M lily/dynamic-performer.cc View 4 chunks +8 lines, -3 lines 0 comments Download
M lily/episema-engraver.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M lily/extender-engraver.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M lily/figured-bass-engraver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/figured-bass-position-engraver.cc View 1 chunk +11 lines, -6 lines 0 comments Download
M lily/fingering-column-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/fingering-engraver.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M lily/font-size-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/footnote-engraver.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M lily/forbid-break-engraver.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M lily/fretboard-engraver.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M lily/glissando-engraver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/grace-engraver.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M lily/grace-spacing-engraver.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M lily/grid-line-span-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/grid-point-engraver.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M lily/grob-pq-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/horizontal-bracket-engraver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/hyphen-engraver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/include/translator.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/translator.icc View 3 chunks +9 lines, -21 lines 0 comments Download
M lily/instrument-name-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/instrument-switch-engraver.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M lily/keep-alive-together-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/key-engraver.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M lily/key-performer.cc View 2 chunks +6 lines, -1 line 0 comments Download
M lily/kievan-ligature-engraver.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M lily/laissez-vibrer-engraver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/ledger-line-engraver.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M lily/ligature-bracket-engraver.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M lily/lyric-engraver.cc View 2 chunks +6 lines, -1 line 0 comments Download
M lily/lyric-performer.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/mark-engraver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/measure-grouping-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/melody-engraver.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M lily/mensural-ligature-engraver.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M lily/metronome-engraver.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M lily/midi-control-function-performer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M lily/multi-measure-rest-engraver.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M lily/new-fingering-engraver.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M lily/note-head-line-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/note-heads-engraver.cc View 2 chunks +6 lines, -1 line 0 comments Download
M lily/note-name-engraver.cc View 2 chunks +6 lines, -1 line 0 comments Download
M lily/note-performer.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/note-spacing-engraver.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M lily/ottava-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/output-property-engraver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/page-turn-engraver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/paper-column-engraver.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M lily/parenthesis-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/part-combine-engraver.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M lily/percent-repeat-engraver.cc View 2 chunks +6 lines, -1 line 0 comments Download
M lily/phrasing-slur-engraver.cc View 2 chunks +16 lines, -11 lines 0 comments Download
M lily/piano-pedal-align-engraver.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M lily/piano-pedal-engraver.cc View 4 chunks +8 lines, -3 lines 0 comments Download
M lily/piano-pedal-performer.cc View 4 chunks +8 lines, -3 lines 0 comments Download
M lily/pitch-squash-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/pitched-trill-engraver.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M lily/pure-from-neighbor-engraver.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M lily/repeat-acknowledge-engraver.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M lily/repeat-tie-engraver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/rest-collision-engraver.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M lily/rest-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/rhythmic-column-engraver.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M lily/script-column-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/script-engraver.cc View 2 chunks +13 lines, -8 lines 0 comments Download
M lily/script-row-engraver.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M lily/separating-line-group-engraver.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M lily/slash-repeat-engraver.cc View 2 chunks +6 lines, -1 line 0 comments Download
M lily/slur-engraver.cc View 2 chunks +15 lines, -10 lines 0 comments Download
M lily/slur-performer.cc View 2 chunks +6 lines, -1 line 0 comments Download
M lily/spacing-engraver.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M lily/span-arpeggio-engraver.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M lily/span-bar-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/span-bar-stub-engraver.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M lily/spanner-break-forbid-engraver.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M lily/staff-collecting-engraver.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M lily/staff-performer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M lily/staff-symbol-engraver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/stanza-number-align-engraver.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M lily/stanza-number-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/stem-engraver.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M lily/system-start-delimiter-engraver.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M lily/tab-note-heads-engraver.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M lily/tab-staff-symbol-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/tab-tie-follow-engraver.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M lily/tempo-performer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M lily/text-engraver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/text-spanner-engraver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/tie-engraver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/tie-performer.cc View 2 chunks +6 lines, -1 line 0 comments Download
M lily/time-signature-engraver.cc View 2 chunks +6 lines, -1 line 0 comments Download
M lily/time-signature-performer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M lily/timing-translator.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M lily/trill-spanner-engraver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/tuplet-engraver.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M lily/tweak-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/vaticana-ligature-engraver.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M lily/vertical-align-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/volta-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b