Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11)

Issue 29450043: Refactor provisioner (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by wallyworld
Modified:
11 years, 3 months ago
Reviewers:
thumper, mp+195901
Visibility:
Public.

Description

Refactor provisioner The provisioner is refactored to provide 2 implementations, a environ provisioner and a container provisioner. The provisioner no longer has any container specific knowledge; that is all done in the container initialisation helper which has recently been introduced to handle container initialisation. The common provisioner logic is all packaged together, and interfaces are used where necessary eg to allow the common logic to get the correct watcher. https://code.launchpad.net/~wallyworld/juju-core/refactor-provisioner/+merge/195901 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -183 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/jujud/machine.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/provisioner/container_initialisation.go View 4 chunks +24 lines, -19 lines 0 comments Download
M worker/provisioner/container_initialisation_test.go View 6 chunks +13 lines, -7 lines 0 comments Download
M worker/provisioner/export_test.go View 1 chunk +5 lines, -4 lines 0 comments Download
M worker/provisioner/lxc-broker_test.go View 1 chunk +5 lines, -2 lines 0 comments Download
M worker/provisioner/provisioner.go View 7 chunks +164 lines, -144 lines 0 comments Download
M worker/provisioner/provisioner_test.go View 4 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 2
wallyworld
Please take a look.
11 years, 3 months ago (2013-11-20 04:55:44 UTC) #1
thumper
11 years, 3 months ago (2013-11-21 22:31:23 UTC) #2
LGTM

Thanks for this refactoring, makes things much nicer.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b