Issue 294490043: Add a context size change test.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 294490043: Add a context size change test. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by erikchen1

Modified:
9 years, 9 months ago

Reviewers:
kbr1

Base URL:
https://chromium.googlesource.com/external/khronosgroup/webgl.git@master

Visibility:
Public.

More Reviews

Description

Add a context size change test. The test makes an antialiased, no alpha context. Then it resizes it, and checks that clearing/reading the resized context still works. BUG=595948

Patch Set 1 #

Patch Set 2 : #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -0 lines)			Patch
	M	sdk/tests/conformance/context/00_test_list.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A	sdk/tests/conformance/context/context-size-change.html	View	1	1 chunk	+113 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

kbr1

On 2016/05/03 22:48:51, erikchen1 wrote: > kbr: Please review. Thanks for putting this together. The ...

9 years, 9 months ago (2016-05-03 23:16:37 UTC) #2

erikchen1

9 years, 9 months ago (2016-05-04 00:33:37 UTC) #3

On 2016/05/03 23:16:37, kbr1 wrote:
> On 2016/05/03 22:48:51, erikchen1 wrote:
> > kbr: Please review.
> 
> Thanks for putting this together. The way to add tests is to fork
> https://github.com/KhronosGroup/WebGL and submit a pull request against it per
> https://www.khronos.org/webgl/wiki/Using_Github_To_Contribute . Could you do
> that? I'll help you roll the WebGL conformance suite after it's landed there,
> and we don't have to block your Chromium CL on that.
> 
> We should close this review request -- it won't work (I don't even know what
> would happen if it were committed).

Done: https://github.com/KhronosGroup/WebGL/pull/1646

Expand All Messages | Collapse All Messages