Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(48)

Issue 294330043: Remove routing information from Grob_info

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by pkx166h
Modified:
3 years, 4 months ago
Reviewers:
dak, carl.d.sorensen, Carl
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Remove routing information from Grob_info It passes information to acknowledgers that does not really belong there and instead manages how information gets there. Moving this information into arguments for the various kinds of announce_grob procedure is cleaner and allows to bounce Grob_info through Scheme without the danger of information loss.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Instead of START this must be start_end #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -47 lines) Patch
M lily/auto-beam-engraver.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M lily/engraver.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M lily/engraver-group.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M lily/grob-info.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M lily/include/engraver.hh View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/include/engraver-group.hh View 2 chunks +13 lines, -2 lines 0 comments Download
M lily/include/grob-info.hh View 3 chunks +3 lines, -14 lines 0 comments Download
M lily/include/score-engraver.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/score-engraver.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M lily/span-bar-stub-engraver.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3
dak
https://codereview.appspot.com/294330043/diff/1/lily/score-engraver.cc File lily/score-engraver.cc (left): https://codereview.appspot.com/294330043/diff/1/lily/score-engraver.cc#oldcode160 lily/score-engraver.cc:160: Engraver_group::announce_grob (info); I guess this is the one. Instead ...
3 years, 4 months ago (2016-04-27 08:31:56 UTC) #1
pkx166h
Instead of START this must be start_end
3 years, 4 months ago (2016-04-28 06:11:08 UTC) #2
Carl
3 years, 4 months ago (2016-04-28 14:20:34 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b