Issue 293710043: Integrate Type1 font embedding procedures

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 293710043: Integrate Type1 font embedding procedures

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 10 months ago by trueroad

Modified:
7 years, 10 months ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Issue 4889/2: Integrate Type1 font embedding procedures For embedding both PFA and PFB fonts are used the same procedure `ly:type1->pfa`. Issue 4889/1: Rewrite Type1 font converting procedures This commit rewrites `ly:pfb->pfa` to `ly:type1->pfa`. For PFA fonts, it passes through the PFA. For PFB fonts, it converts the PFB to PFA.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix space and comment #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -11 lines)			Patch
	M	lily/pfb-scheme.cc	View	1	1 chunk	+22 lines, -9 lines	0 comments	Download
	M	scm/framework-ps.scm	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

lemzwerg

LGTM. https://codereview.appspot.com/293710043/diff/1/lily/pfb-scheme.cc File lily/pfb-scheme.cc (right): https://codereview.appspot.com/293710043/diff/1/lily/pfb-scheme.cc#newcode13 lily/pfb-scheme.cc:13: " to PFA format. If the file is ...

7 years, 10 months ago (2016-06-07 15:42:06 UTC) #1

trueroad

Thank you for your review. https://codereview.appspot.com/293710043/diff/1/lily/pfb-scheme.cc File lily/pfb-scheme.cc (right): https://codereview.appspot.com/293710043/diff/1/lily/pfb-scheme.cc#newcode13 lily/pfb-scheme.cc:13: " to PFA format. ...

7 years, 10 months ago (2016-06-07 16:31:53 UTC) #3

trueroad

7 years, 10 months ago (2016-06-15 15:13:31 UTC) #4

I've pushed to staging.

Issue 4889/1: Rewrite Type1 font converting procedures
commit 20566977015b8bf1979c6d6fea8fe5df0df756e4

Issue 4889/2: Integrate Type1 font embedding procedures
commit 2a058ff68e446d71f51000bce12f7c13f983ef9d

Expand All Messages | Collapse All Messages