Issue 29320043: make PathObserver.defineProperty take four arguments and avoid needless allocation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29320043: make PathObserver.defineProperty take four arguments and avoid needless allocation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by rafaelw

Modified:
12 years ago

Reviewers:
arv

Base URL:
https://github.com/Polymer/observe-js.git@master

Visibility:
Public.

More Reviews

Description

make PathObserver.defineProperty take four arguments and avoid needless allocation R=arv BUG= Committed: https://github.com/Polymer/observe-js/commit/6da3137

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -34 lines)			Patch
	M	src/observe.js	View		1 chunk	+9 lines, -10 lines	0 comments	Download
	M	tests/test.js	View		3 chunks	+10 lines, -24 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rafaelw

Committed patchset #1 manually as r6da3137 (presubmit successful).

12 years ago (2013-11-19 22:34:44 UTC) #1

Message was sent while issue was closed.

LGTM

Expand All Messages | Collapse All Messages