Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(115)

Issue 293030043: Update of test.py

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by mattator
Modified:
10 years ago
Reviewers:
Tommaso Pecorella
Visibility:
Public.

Description

Update of test.py

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -122 lines) Patch
M test.py View 26 chunks +112 lines, -122 lines 1 comment Download

Messages

Total messages: 3
Tommaso Pecorella
I'm not a Python coder, so I don't know where the problem is. On a ...
10 years ago (2016-04-04 13:32:41 UTC) #1
mattator
On 2016/04/04 13:32:41, Tommaso Pecorella wrote: > I'm not a Python coder, so I don't ...
10 years ago (2016-04-04 13:40:28 UTC) #2
Tommaso Pecorella
10 years ago (2016-04-04 13:50:21 UTC) #3
On 2016/04/04 13:40:28, mattator wrote:
> On 2016/04/04 13:32:41, Tommaso Pecorella wrote:
> > I'm not a Python coder, so I don't know where the problem is.
> > On a MacOS X (Python 2.7.10), the result is:
> > 
> > tommy-pc:ns-3-dev pecos$ ./test.py -s sixlowpan-iphc 
> > Traceback (most recent call last):
> >   File "./test.py", line 1925, in <module>
> >     sys.exit(main(sys.argv))
> >   File "./test.py", line 1922, in main
> >     return run_tests(unknown_args)
> >   File "./test.py", line 1085, in run_tests
> >     elif len(options.example):
> > TypeError: object of type 'NoneType' has no len()
> > tommy-pc:ns-3-dev pecos$
> > 
> > https://codereview.appspot.com/293030043/diff/1/test.py
> > File test.py (right):
> > 
> > https://codereview.appspot.com/293030043/diff/1/test.py#newcode1292
> > test.py:1292: #
> > If there's no more code following this comment, perhaps its position is
wrong.
> 
> I am surprised python didn't choke sooner since the script relies on
"argparse"
> (superseeding optparse) and is only available in python3 "New in version
3.2.".
> Thus this new test.py only works with python >= 3.2.
> 
> Also note that when using this script you should run "python3 ./waf configure"
> since waf will generate different lock filenames depending on python2 or
python3
> use (sys.PLATFORM returns "linux2" in python2 and "linux" in python3).
> 
> Could you rerun with python3 ?
> Thanks for testing !

ns-3 reconfigured with Python 3.4 and rebuilt.
tommy-pc:ns-3-dev pecos$ python3.4 test.py -s sixlowpan-iphc 
Traceback (most recent call last):
  File "test.py", line 1925, in <module>
    sys.exit(main(sys.argv))
  File "test.py", line 1922, in main
    return run_tests(unknown_args)
  File "test.py", line 1085, in run_tests
    elif len(options.example):
TypeError: object of type 'NoneType' has no len()

No luck.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b