Issue 29210043: Add a script to remove a charm

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29210043: Add a script to remove a charm

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by benji

Modified:
10 years, 5 months ago

Reviewers:
bac, rharding, mp+195839

Visibility:
Public.

Description

Add a script to remove a charm https://code.launchpad.net/~benji/charmworld/remove-charm/+merge/195839 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+218 lines, -1 line)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charmworld/models.py	View	2 chunks	+13 lines, -0 lines	0 comments	Download
A	charmworld/scripts/remove_charm.py	View	1 chunk	+71 lines, -0 lines	0 comments	Download
A	charmworld/scripts/tests/test_remove_charm.py	View	1 chunk	+119 lines, -0 lines	3 comments	Download
M	charmworld/search.py	View	1 chunk	+1 line, -1 line	1 comment	Download
M	charmworld/testing/factory.py	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	setup.py	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bac

LGTM. Cannot do QA at this time. https://codereview.appspot.com/29210043/diff/1/charmworld/scripts/tests/test_remove_charm.py File charmworld/scripts/tests/test_remove_charm.py (right): https://codereview.appspot.com/29210043/diff/1/charmworld/scripts/tests/test_remove_charm.py#newcode53 charmworld/scripts/tests/test_remove_charm.py:53: # A ...

10 years, 5 months ago (2013-11-19 19:05:47 UTC) #2

rharding

Search QA is ok. Search change just made it so that ~charmers works vs produces ...

10 years, 5 months ago (2013-11-19 19:58:34 UTC) #3

benji

10 years, 5 months ago (2013-11-19 20:25:35 UTC) #4

Thanks for the review and QA guys!

https://codereview.appspot.com/29210043/diff/1/charmworld/scripts/tests/test_...
File charmworld/scripts/tests/test_remove_charm.py (right):

https://codereview.appspot.com/29210043/diff/1/charmworld/scripts/tests/test_...
charmworld/scripts/tests/test_remove_charm.py:53: # A non-zero exit status is
set to indicate the error condition.
On 2013/11/19 19:05:48, bac wrote:
> positive, non-zero

Since POSIX requires it to be an "unsigned decimal integer", all non-zero values
are positive. ;)

Expand All Messages | Collapse All Messages