Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(464)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
29200043
: Checking in version 1908 release binaries. (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by
chrisha
Modified:
11 years, 1 month ago
Reviewers:
Sébastien Marchand
,
etienneb
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk
Visibility:
Public.
More Reviews
Description
Checking in version 1908 release binaries. BUG= R=etienneb@chromium.org, sebmarchand@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=1909
Patch Set 1
#
Created:
11 years, 1 month ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+17 lines, -2 lines
)
Patch
M
syzygy/binaries/Benchmark_Chrome-0.1_r1825-py2.6.egg
View
Binary file
0 comments
Download
M
syzygy/binaries/ETW-0.6.5.0-py2.6.egg
View
Binary file
0 comments
Download
M
syzygy/binaries/ETW_Db-0.1_r1543-py2.6.egg
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/README.TXT
View
2 chunks
+13 lines, -2 lines
0 comments
Download
M
syzygy/binaries/exe/RELEASE-NOTES.TXT
View
1 chunk
+4 lines, -0 lines
0 comments
Download
M
syzygy/binaries/exe/agent_logger.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/basic_block_entry_client.dll
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/basic_block_entry_client.dll.pdb
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/call_trace_client.dll
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/call_trace_client.dll.pdb
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/call_trace_control.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/call_trace_service.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/coverage_client.dll
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/coverage_client.dll.pdb
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/decompose.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/decompose_image_to_text.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/dump_trace.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/experimental/code_tally.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/experimental/compare.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/experimental/pdb_dumper.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/experimental/timed_decomposer.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/genfilter.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/grinder.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/instrument.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/pdbfind.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/profile_client.dll
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/profile_client.dll.pdb
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/relink.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/reorder.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/run_in_snapshot.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/run_in_snapshot_x64.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/run_in_snapshot_xp.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/sampler.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/simulate.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/syzyasan_rtl.dll
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/syzyasan_rtl.dll.pdb
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/wsdump.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/exe/zap_timestamp.exe
View
Binary file
0 comments
Download
M
syzygy/binaries/lib/syzyasan_rtl.lib
View
Binary file
0 comments
Download
Messages
Total messages: 5
Expand All Messages
|
Collapse All Messages
chrisha
PTAL
11 years, 1 month ago (2013-11-19 18:01:14 UTC)
#1
PTAL
Sign in
to reply to this message.
Sébastien Marchand
lgtm
11 years, 1 month ago (2013-11-19 18:03:40 UTC)
#2
lgtm
Sign in
to reply to this message.
etienneb
lgtm.
11 years, 1 month ago (2013-11-19 18:27:55 UTC)
#3
lgtm.
Sign in
to reply to this message.
chrisha
Thanks, committing.
11 years, 1 month ago (2013-11-19 18:36:53 UTC)
#4
Thanks, committing.
Sign in
to reply to this message.
chrisha
Committed patchset #1 manually as r1909 (presubmit successful).
11 years, 1 month ago (2013-11-19 18:39:23 UTC)
#5
Message was sent while issue was closed.
Committed patchset #1 manually as r1909 (presubmit successful).
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 29200043: Checking in version 1908 release binaries. (Closed)
Created 11 years, 1 month ago by chrisha
Modified 11 years, 1 month ago
Reviewers: Sébastien Marchand, etienneb
Base URL: http://sawbuck.googlecode.com/svn/trunk
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b
