Issue 2917041: Do not return type=url views for gadgets that are to be sanitized

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2917041: Do not return type=url views for gadgets that are to be sanitized

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by jtarrio

Modified:
15 years, 4 months ago

Reviewers:
zhoresh, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

Type=url views cannot be sanitized, as GGS does not get to see that content. With this patch, such views are removed when the container says that it wants to sanitize the gadget.

Patch Set 1 #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+69 lines, -17 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetContext.java	View	1 chunk	+7 lines, -0 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java	View	1 chunk	+4 lines, -0 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/GadgetSpec.java	View	2 chunks	+18 lines, -0 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/process/ProcessorTest.java	View	4 chunks	+17 lines, -4 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java	View	8 chunks	+10 lines, -2 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/UriManagerTestBase.java	View	2 chunks	+12 lines, -11 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lgtm, committing

Expand All Messages | Collapse All Messages