Issue 290900043: Bug 1126830 - Prioritize ChaCha20/Poly1305 ciphers over AES-GCM for ARM builds

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 290900043: Bug 1126830 - Prioritize ChaCha20/Poly1305 ciphers over AES-GCM for ARM builds (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 2 months ago by ttaubert

Modified:
8 years, 2 months ago

Reviewers:
ekr, mt, ekr-rietveld

Visibility:
Public.

More Reviews

Description

Bug 1126830 - Prioritize ChaCha20/Poly1305 ciphers over AES-GCM for ARM builds

Patch Set 2 : Using #if[n]def arm #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
	M	lib/ssl/ssl3con.c	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download
	M	lib/ssl/sslenum.c	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

https://codereview.appspot.com/290900043/diff/1/lib/ssl/ssl3con.c File lib/ssl/ssl3con.c (right): https://codereview.appspot.com/290900043/diff/1/lib/ssl/ssl3con.c#newcode98 lib/ssl/ssl3con.c:98: #if defined(__arm__) The pattern here seems to be `#if[n]def ...

8 years, 2 months ago (2016-02-23 16:09:31 UTC) #1

ttaubert

8 years, 2 months ago (2016-02-23 18:34:54 UTC) #2

Patch set 2 LGTM

Expand All Messages | Collapse All Messages