Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2470)

Issue 28980043: state: factor out addmachine logic

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years ago by rog
Modified:
6 years ago
Reviewers:
gz, mp+195768, william.reade, dimitern
Visibility:
Public.

Description

state: factor out addmachine logic Rather than grow state.go even more, this moves the add-machine related code into a new file. The new EnsureAvailability method will be implemented here too. This is just a code move, no logic has been altered. https://code.launchpad.net/~rogpeppe/juju-core/464-state-addmachine-move/+merge/195768 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -238 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
A state/addmachine.go View 1 chunk +244 lines, -0 lines 0 comments Download
M state/container.go View 1 chunk +8 lines, -0 lines 0 comments Download
M state/state.go View 2 chunks +0 lines, -238 lines 0 comments Download

Messages

Total messages: 4
rog
Please take a look.
6 years ago (2013-11-19 12:59:05 UTC) #1
william.reade
Wow, you can see what's going on! LGTM.
6 years ago (2013-11-19 13:01:22 UTC) #2
gz
LGTM.
6 years ago (2013-11-19 13:27:28 UTC) #3
dimitern
6 years ago (2013-11-19 13:28:00 UTC) #4
Excellent! LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b