Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(511)

Issue 289570043: Use ssl._create_unverified_context() only if available

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by bashi
Modified:
9 years, 5 months ago
Reviewers:
nednguyen
Base URL:
https://github.com/chromium/web-page-replay.git@master
Visibility:
Public.

Description

Use ssl._create_unverified_context() only if available It's only available Python 2.7.9 or later. BUG=#66

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M httpclient.py View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7
bashi
PTAL
9 years, 5 months ago (2016-03-22 03:00:15 UTC) #1
nednguyen
https://codereview.appspot.com/289570043/diff/1/httpclient.py File httpclient.py (right): https://codereview.appspot.com/289570043/diff/1/httpclient.py#newcode190 httpclient.py:190: try: Instead of try except, how about: if hasattr(ssl, ...
9 years, 5 months ago (2016-03-22 03:49:34 UTC) #2
bashi
Thanks for review! https://codereview.appspot.com/289570043/diff/1/httpclient.py File httpclient.py (right): https://codereview.appspot.com/289570043/diff/1/httpclient.py#newcode190 httpclient.py:190: try: On 2016/03/22 03:49:34, nednguyen wrote: ...
9 years, 5 months ago (2016-03-22 03:53:08 UTC) #3
nednguyen
On 2016/03/22 03:53:08, bashi wrote: > Thanks for review! > > https://codereview.appspot.com/289570043/diff/1/httpclient.py > File httpclient.py ...
9 years, 5 months ago (2016-03-22 03:54:27 UTC) #4
bashi
On 2016/03/22 03:54:27, nednguyen wrote: > On 2016/03/22 03:53:08, bashi wrote: > > Thanks for ...
9 years, 5 months ago (2016-03-22 03:56:22 UTC) #5
nednguyen
On 2016/03/22 03:56:22, bashi wrote: > On 2016/03/22 03:54:27, nednguyen wrote: > > On 2016/03/22 ...
9 years, 5 months ago (2016-03-22 04:01:08 UTC) #6
bashi
9 years, 5 months ago (2016-03-22 04:19:23 UTC) #7
On 2016/03/22 04:01:08, nednguyen wrote:
> On 2016/03/22 03:56:22, bashi wrote:
> > On 2016/03/22 03:54:27, nednguyen wrote:
> > > On 2016/03/22 03:53:08, bashi wrote:
> > > > Thanks for review!
> > > > 
> > > > https://codereview.appspot.com/289570043/diff/1/httpclient.py
> > > > File httpclient.py (right):
> > > > 
> > > > https://codereview.appspot.com/289570043/diff/1/httpclient.py#newcode190
> > > > httpclient.py:190: try:
> > > > On 2016/03/22 03:49:34, nednguyen wrote:
> > > > > Instead of try except, how about:
> > > > > if hasattr(ssl, "_create_unverified_context"):
> > > > >     ...
> > > > > else:
> > > > 
> > > > Done.
> > > 
> > > lgtm
> > > 
> > > After I helped with commiting this patch, can you manually update the
> > > web-page-replay version in catapult/telemetry/third_party as well?
> > 
> > Sure. Thanks for the help!
> 
> Patch landed in
>
https://github.com/chromium/web-page-replay/commit/b03f84da6e90951d4275b56755...

Thanks. Prepared roll:
https://codereview.chromium.org/1821953002/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b