On 2016/03/22 03:53:08, bashi wrote: > Thanks for review! > > https://codereview.appspot.com/289570043/diff/1/httpclient.py > File httpclient.py ...
9 years, 5 months ago
(2016-03-22 03:54:27 UTC)
#4
On 2016/03/22 03:53:08, bashi wrote:
> Thanks for review!
>
> https://codereview.appspot.com/289570043/diff/1/httpclient.py
> File httpclient.py (right):
>
> https://codereview.appspot.com/289570043/diff/1/httpclient.py#newcode190
> httpclient.py:190: try:
> On 2016/03/22 03:49:34, nednguyen wrote:
> > Instead of try except, how about:
> > if hasattr(ssl, "_create_unverified_context"):
> > ...
> > else:
>
> Done.
lgtm
After I helped with commiting this patch, can you manually update the
web-page-replay version in catapult/telemetry/third_party as well?
Issue 289570043: Use ssl._create_unverified_context() only if available
Created 9 years, 5 months ago by bashi
Modified 9 years, 5 months ago
Reviewers: nednguyen
Base URL: https://github.com/chromium/web-page-replay.git@master
Comments: 2