Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(415)

Issue 289430043: Don't warn if DISPLAY is not set (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 1 month ago by fujiwara
Modified:
8 years, 1 month ago
Reviewers:
shawn.p.huang
CC:
shawn.p.huang_gmail.com, mclasen_redhat.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Don't warn if DISPLAY is not set This is normal under Wayland, and not worth warning about. The warnings disrupt unit tests in GNOME continuous, which treat warnings as fatal. BUG=https://github.com/ibus/ibus/pull/1844 R=shawn.p.huang@gmail.com Committed: 0432aa66b8728bc266da3c2cca84587bc44b3557

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M src/ibusshare.c View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 3
fujiwara
8 years, 1 month ago (2016-03-07 12:08:52 UTC) #1
shawn.p.huang_gmail.com
lgtm On Mon, Mar 7, 2016, 07:08 <takao.fujiwara1@gmail.com> wrote: > Reviewers: shawn.p.huang_gmail.com, > > Description: ...
8 years, 1 month ago (2016-03-07 13:39:18 UTC) #2
fujiwara
8 years, 1 month ago (2016-03-08 02:16:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0432aa66b8728bc266da3c2cca84587bc44b3557 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b