Issue 2886041: code review 2886041: add hardware floating point.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2886041: code review 2886041: add hardware floating point. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by ken3

Modified:
14 years, 4 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

add hardware floating point. currently, softfloat does not work and there are some unsigned-to-float conversion errors.

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1414 lines, -87 lines)			Patch
M	src/cmd/5g/Makefile	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/5g/gg.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/cmd/5g/ggen.c	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/cmd/5g/list.c	View	1 chunk	+8 lines, -6 lines	0 comments	Download
M	src/cmd/5g/opt.h	View	1 chunk	+1 line, -1 line	0 comments	Download
A	src/cmd/5g/reg.c	View	1 chunk	+1246 lines, -0 lines	0 comments	Download
M	src/cmd/5l/5.out.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/5l/asm.c	View	7 chunks	+120 lines, -60 lines	0 comments	Download
M	src/cmd/5l/l.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	src/cmd/5l/list.c	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/cmd/5l/obj.c	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/cmd/5l/optab.c	View	1 chunk	+6 lines, -7 lines	0 comments	Download
M	src/cmd/5l/softfloat.c	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/cmd/5l/span.c	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	src/cmd/5l/thumb.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/print.c	View	2 chunks	+1 line, -1 line	0 comments	Download

Total messages: 3

ken3

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 4 months ago (2010-11-04 00:31:05 UTC) #1

ken3

*** Submitted as http://code.google.com/p/go/source/detail?r=3e8c5af7bb1a *** add hardware floating point. currently, softfloat does not work and ...

14 years, 4 months ago (2010-11-04 00:31:12 UTC) #2

LGTM