Issue 288320043: ticket:12012: Replace all sizeof p / sizeof T with UPRV_LENGTHOF().

Issue 288320043: ticket:12012: Replace all sizeof p / sizeof T with UPRV_LENGTHOF(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 8 months ago by roubert (google)

Modified:
8 years, 8 months ago

Reviewers:
markus.icu

Base URL:
svn+ssh://source.icu-project.org/repos/icu/icu/trunk

Visibility:
Public.

More Reviews

Description

ticket:12012: Replace all sizeof p / sizeof T with UPRV_LENGTHOF(). R=markus.icu@gmail.com Committed: http://bugs.icu-project.org/trac/changeset/38347

Patch Set 2 : Code review. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -76 lines)			Patch
M	source/common/locmap.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	source/common/ucnv.c	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	source/i18n/repattrn.cpp	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	source/i18n/uspoof_impl.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	source/io/uprntf_p.c	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	source/test/cintltst/ccaltst.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	source/test/cintltst/ccapitst.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	source/test/cintltst/cloctst.c	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	source/test/cintltst/cucdapi.c	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	source/test/cintltst/custrtst.c	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	source/test/cintltst/nucnvtst.c	View		11 chunks	+11 lines, -11 lines	0 comments	Download
M	source/test/cintltst/spooftest.c	View		3 chunks	+5 lines, -4 lines	0 comments	Download
M	source/test/cintltst/usrchtst.c	View	1	4 chunks	+7 lines, -7 lines	0 comments	Download
M	source/test/intltest/icusvtst.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	source/test/intltest/itrbnf.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	source/test/intltest/numfmtst.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	source/test/intltest/rbbitst.cpp	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	source/test/intltest/tfsmalls.cpp	View		3 chunks	+5 lines, -6 lines	0 comments	Download
M	source/test/intltest/tmsgfmt.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	source/test/intltest/tufmtts.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	source/test/intltest/tzrulets.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	source/test/intltest/utxttest.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	source/test/iotest/stream.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	source/test/perf/normperf/dtfmtrtperf.h	View		5 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

roubert (google)

This requires a little bit more manual intervention, checking that every p really is of ...

8 years, 8 months ago (2016-02-24 20:33:53 UTC) #1

markus.icu

LGTM Just one nit. https://codereview.appspot.com/288320043/diff/1/source/test/cintltst/usrchtst.c File source/test/cintltst/usrchtst.c (right): https://codereview.appspot.com/288320043/diff/1/source/test/cintltst/usrchtst.c#newcode2 source/test/cintltst/usrchtst.c:2: * Copyright (c) 2001-2011,2015,2016 International ...

8 years, 8 months ago (2016-02-24 21:22:50 UTC) #2

roubert (google)

https://codereview.appspot.com/288320043/diff/1/source/test/cintltst/usrchtst.c File source/test/cintltst/usrchtst.c (right): https://codereview.appspot.com/288320043/diff/1/source/test/cintltst/usrchtst.c#newcode2 source/test/cintltst/usrchtst.c:2: * Copyright (c) 2001-2011,2015,2016 International Business Machines On 2016/02/24 ...

8 years, 8 months ago (2016-02-24 21:48:30 UTC) #3

roubert (google)

8 years, 8 months ago (2016-02-24 21:49:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 38347 (presubmit successful).

Expand All Messages | Collapse All Messages