Issue 286440043: ticket:12164: Add using operator to all subclasses of LocalPointerBase.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 286440043: ticket:12164: Add using operator to all subclasses of LocalPointerBase. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 8 months ago by roubert (google)

Modified:
8 years, 8 months ago

Reviewers:
markus.icu

Base URL:
svn+ssh://source.icu-project.org/repos/icu/icu/trunk

Visibility:
Public.

More Reviews

Description

ticket:12164: Add using operator to all subclasses of LocalPointerBase. This will add operator* and operator-> from LocalPointerBase to the scope of each subclass. R=markus.icu@gmail.com Committed: http://bugs.icu-project.org/trac/changeset/38379

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	source/common/cmemory.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
	M	source/common/unicode/localpointer.h	View	1	4 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

markus.icu

LGTM https://codereview.appspot.com/286440043/diff/1/source/common/cmemory.h File source/common/cmemory.h (right): https://codereview.appspot.com/286440043/diff/1/source/common/cmemory.h#newcode4 source/common/cmemory.h:4: * Copyright (C) 1997-2015, International Business Machines 2016

8 years, 8 months ago (2016-02-25 18:37:07 UTC) #2

roubert (google)

https://codereview.appspot.com/286440043/diff/1/source/common/cmemory.h File source/common/cmemory.h (right): https://codereview.appspot.com/286440043/diff/1/source/common/cmemory.h#newcode4 source/common/cmemory.h:4: * Copyright (C) 1997-2015, International Business Machines On 2016/02/25 ...

8 years, 8 months ago (2016-02-26 11:24:12 UTC) #3

roubert (google)

8 years, 8 months ago (2016-02-26 11:24:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 38379 (presubmit successful).

Expand All Messages | Collapse All Messages