Issue 286200043: Bug 1246939 - Implement PKCS#11 bypass for ChaCha20/Poly1305 cipher suite

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 286200043: Bug 1246939 - Implement PKCS#11 bypass for ChaCha20/Poly1305 cipher suite (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 2 months ago by ttaubert

Modified:
8 years, 2 months ago

Reviewers:
ekr, ekr-rietveld

Visibility:
Public.

More Reviews

Description

Bug 1246939 - Implement PKCS#11 bypass for ChaCha20/Poly1305 cipher suite

Patch Set 1 #

Patch Set 2 : Bug 1246939 - Pretend to support the PKCS#11 bypass for ChaCha20/Poly1305 #

Patch Set 3 : Bug 1246939 - Ignore PKCS#11 bypass for ChaCha20/Poly1305 #

Patch Set 4 : Bug 1227905 - Disable PKCS#11 bypass for ChaCha20/Poly1305 #

Total comments: 3

Patch Set 5 : Bug 1227905 - Disable PKCS#11 bypass for ChaCha20/Poly1305 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	lib/ssl/ssl3con.c	View	1 2 3 4	2 chunks	+17 lines, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

ekr-rietveld

8 years, 2 months ago (2016-02-10 09:12:12 UTC) #1

LGTM but with suggested interface change.

https://codereview.appspot.com/286200043/diff/60001/lib/ssl/ssl3con.c
File lib/ssl/ssl3con.c (right):

https://codereview.appspot.com/286200043/diff/60001/lib/ssl/ssl3con.c#newcode...
lib/ssl/ssl3con.c:2261: * We do not support PKCS#11 bypass for
ChaCha20/Poly1305.
I apologize but I think it would be better to have this take a 
const ssl3CipherSuiteDef *.

https://codereview.appspot.com/286200043/diff/60001/lib/ssl/ssl3con.c#newcode...
lib/ssl/ssl3con.c:2263: PRBool
This should be static.

https://codereview.appspot.com/286200043/diff/60001/lib/ssl/ssl3con.c#newcode...
lib/ssl/ssl3con.c:2267: case calg_chacha20:
NSS style is to indent the cases.

Expand All Messages | Collapse All Messages