8 years, 3 months ago
(2016-01-13 04:32:15 UTC)
#2
lgtm
<takao.fujiwara1@gmail.com>于2016年1月12日周二 23:07写道:
> Reviewers: shawn.p.huang_gmail.com,
>
> Description:
> setup: Fix PyGIWarning: GdkX11 was imported without specifying a version
>
> Please review this at https://codereview.appspot.com/285830043/
>
> Affected files (+9, -2 lines):
> M setup/main.py
>
>
> Index: setup/main.py
> diff --git a/setup/main.py b/setup/main.py
> index
>
>
22b6dc77c44223a9baeb4afc3be845756d4fed3e..26c2b0f3f6b19fcd380317de839ef563f39661cf
> 100644
> --- a/setup/main.py
> +++ b/setup/main.py
> @@ -2,8 +2,8 @@
> #
> # ibus - The Input Bus
> #
> -# Copyright (c) 2007-2015 Peng Huang <shawn.p.huang@gmail.com>
> -# Copyright (c) 2007-2015 Red Hat, Inc.
> +# Copyright (c) 2007-2016 Peng Huang <shawn.p.huang@gmail.com>
> +# Copyright (c) 2007-2016 Red Hat, Inc.
> #
> # This library is free software; you can redistribute it and/or
> # modify it under the terms of the GNU Lesser General Public
> @@ -28,6 +28,13 @@ import signal
> import sys
> import time
>
> +from gi import require_version as gi_require_version
> +gi_require_version('GLib', '2.0')
> +gi_require_version('GdkX11', '3.0')
> +gi_require_version('Gio', '2.0')
> +gi_require_version('Gtk', '3.0')
> +gi_require_version('IBus', '1.0')
> +
> from gi.repository import GLib
> # set_prgname before importing other modules to show the name in warning
> # messages when import modules are failed.
>
>
>
Issue 285830043: setup: Fix PyGIWarning: GdkX11 was imported without specifying a version
(Closed)
Created 8 years, 3 months ago by fujiwara
Modified 8 years, 3 months ago
Reviewers: shawn.p.huang_gmail.com
Base URL: git@github.com:ibus/ibus.git@master
Comments: 0