Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(104)

Issue 2853042: code review 2853042: Effective Go: correct error in recent edit: "..." is in... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by r
Modified:
14 years, 4 months ago
Reviewers:
CC:
rsc, gri, golang-dev
Visibility:
Public.

Description

Effective Go: correct error in recent edit: "..." is in call to Sprintln, not Output.

Patch Set 1 #

Patch Set 2 : code review 2853042: Effective Go: correct error in recent edit: "..." is in... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M doc/effective_go.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
r
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 4 months ago (2010-11-03 18:00:47 UTC) #1
gri
LGTM On Wed, Nov 3, 2010 at 11:00 AM, <r@golang.org> wrote: > Reviewers: rsc, > ...
14 years, 4 months ago (2010-11-03 18:07:54 UTC) #2
r
14 years, 4 months ago (2010-11-03 18:09:49 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=f34f64eeee51 ***

Effective Go: correct error in recent edit: "..." is in call to Sprintln, not
Output.

R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/2853042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b