Add proxy request to GadgetHandler

Basically expose as part of GadgetHandler (json api) a way to create proxy request url (with version), and even get the proxy data in Base64 format.

[zhoresh, 2010-11-03 17:29:25]

Add support for "1" as true value for booleans

[johnfargo, 2010-11-03 22:08:37]

Great work. Minor comments.

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/main/java/or...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
(right):

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java:176:
// The BaseRequest.url store the rsource to proxy
nit: s/rsource/resource/

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/main/java/or...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
(right):

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:224:
return createProxyResponse(uris.get(0), httpResponse , fields,
micronit: extra space before ,

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:378:
proxyUri.setResize( image.getWidth(), image.getHeight(), image.getQuality(),
image.getDoNotExpand());
>100char

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:378:
proxyUri.setResize( image.getWidth(), image.getHeight(), image.getQuality(),
image.getDoNotExpand());
>100char

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:420:
.build()),
why not return a GadgetsHandler.ProxyRequestData?

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/test/java/or...
File
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java
(right):

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/test/java/or...
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java:289:
assertTrue("Expect same uri", pUri.equals(expectedUri));
not assertEquals?

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/test/java/or...
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java:303:
HttpResponseBuilder httpResponse = new HttpResponseBuilder();
turn @303-323 into a new test.

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/test/java/or...
File
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java
(right):

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/test/java/or...
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java:421:
.put("resize_q", "88")
For readability, I'd recommend writing this as:
JSONObject req = new JSONObject("{ method: gadgets.proxy <etc etc etc>")...

[zhoresh, 2010-11-03 23:44:20]

Thanks for the review, will update patch in a sec.

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/main/java/or...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
(right):

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java:176:
// The BaseRequest.url store the rsource to proxy
On 2010/11/03 22:08:37, johnfargo wrote:
> nit: s/rsource/resource/

Done.

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/main/java/or...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
(right):

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:224:
return createProxyResponse(uris.get(0), httpResponse , fields,
On 2010/11/03 22:08:37, johnfargo wrote:
> micronit: extra space before ,

Done.

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:378:
proxyUri.setResize( image.getWidth(), image.getHeight(), image.getQuality(),
image.getDoNotExpand());
On 2010/11/03 22:08:37, johnfargo wrote:
> >100char

Done.

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:420:
.build()),
On 2010/11/03 22:08:37, johnfargo wrote:
> why not return a GadgetsHandler.ProxyRequestData?

Not sure what you mean, this return response not a request.

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/test/java/or...
File
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java
(right):

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/test/java/or...
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java:289:
assertTrue("Expect same uri", pUri.equals(expectedUri));
On 2010/11/03 22:08:37, johnfargo wrote:
> not assertEquals?

I guess I didn't think assertEquals call equals, but it does, duh!

http://codereview.appspot.com/2851041/diff/3001/java/gadgets/src/test/java/or...
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java:303:
HttpResponseBuilder httpResponse = new HttpResponseBuilder();
On 2010/11/03 22:08:37, johnfargo wrote:
> turn @303-323 into a new test.

Done.

[zhoresh, 2010-11-03 23:44:46]

Update according to Fargo comments

[johnfargo, 2010-11-04 00:17:34]

LGTM

Disregard the ProxyRequestData comment, misread.

On 2010/11/03 23:44:46, zhoresh wrote:
> Update according to Fargo comments