Issue 283550043: Add regtest

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 283550043: Add regtest

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 1 month ago by Carl

Modified:
8 years, 1 month ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Add regtest Use a negative value of overdone_noteheads to shrink the head slightly

Patch Set 1 #

Patch Set 2 : Reload to get onto sourceforge #

Patch Set 3 : Trying again with sourceforge authentication #

Patch Set 4 : Try again with sf key #

Patch Set 5 : Yet another try at git-cl #

Patch Set 6 : Trying again to get Allura to work #

Patch Set 7 : Try again #

Patch Set 8 : Trying after installing ca-certificates #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -1 line)			Patch
	A	input/regression/notehead-height.ly	View		1 chunk	+15 lines, -0 lines	0 comments	Download
	M	mf/feta-params.mf	View		1 chunk	+13 lines, -1 line	1 comment	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

lemzwerg

8 years, 1 month ago (2016-03-13 11:39:02 UTC) #8

LGTM.

https://codereview.appspot.com/283550043/diff/130001/mf/feta-params.mf
File mf/feta-params.mf (right):

https://codereview.appspot.com/283550043/diff/130001/mf/feta-params.mf#newcod...
mf/feta-params.mf:245: % is sometimes an odd number, so the nothead height and
depth are not
s/nothead/notehead/

Expand All Messages | Collapse All Messages