Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(463)

Issue 283040043: engine: Change language code from ISO 639-2 to ISO 639-3 in simple.xml (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by fujiwara
Modified:
8 years, 2 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

engine: Change language code from ISO 639-2 to ISO 639-1 in simple.xml BUG=https://github.com/ibus/ibus/issues/1834 Committed: 3af58fae1710ed3baf800c59da1ab918089c2a9b

Patch Set 1 #

Patch Set 2 : Update header of switcher.vala #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -67 lines) Patch
M engine/Makefile.am View 2 chunks +3 lines, -2 lines 0 comments Download
A engine/iso639converter.py View 1 1 chunk +197 lines, -0 lines 0 comments Download
M engine/simple.xml.in View 61 chunks +61 lines, -61 lines 0 comments Download
M ui/gtk3/switcher.vala View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3
fujiwara
8 years, 2 months ago (2016-01-14 08:40:39 UTC) #1
Peng
lgtm
8 years, 2 months ago (2016-01-14 11:51:44 UTC) #2
fujiwara
8 years, 2 months ago (2016-01-15 02:24:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3af58fae1710ed3baf800c59da1ab918089c2a9b (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b