Issue 282390044: src: Refactor ibuscomposetable.c

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 282390044: src: Refactor ibuscomposetable.c (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 3 months ago by fujiwara

Modified:
8 years, 2 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

src: Refactor ibuscomposetable.c Save raw integers of Unicode instead of code strings. Use g_warning() instead of g_set_error(). BUG=https://bugzilla.gnome.org/show_bug.cgi?id=721120 R=Shawn.P.Huang@gmail.com Committed: 706ba01504a0c48391360a236d7c7aa8e0057753

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+182 lines, -221 lines)			Patch
	M	src/ibuscomposetable.c	View		16 chunks	+182 lines, -221 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fujiwara

Porting https://git.gnome.org/browse/gtk+/commit/?id=138187755fc16afca1898bfae6df8317e1c76429

8 years, 3 months ago (2016-01-29 04:08:33 UTC) #1

Peng

On 2016/01/29 04:08:33, fujiwara wrote: > Porting > https://git.gnome.org/browse/gtk+/commit/?id=138187755fc16afca1898bfae6df8317e1c76429 Sorry. I don't understand this CL, ...

8 years, 2 months ago (2016-01-29 20:18:38 UTC) #2

fujiwara

8 years, 2 months ago (2016-02-01 02:26:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
706ba01504a0c48391360a236d7c7aa8e0057753 (presubmit successful).

Expand All Messages | Collapse All Messages