Issue 281660043: Bug 1245244 - Expose EC_ValidatePublicKey() to PKCS#11

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 281660043: Bug 1245244 - Expose EC_ValidatePublicKey() to PKCS#11

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by ttaubert

Modified:
9 years, 8 months ago

Reviewers:
mt

Visibility:
Public.

More Reviews

Description

Bug 1245244 - Expose EC_ValidatePublicKey() to PKCS#11

Patch Set 1 #

Patch Set 2 : Forgot to free ecparams #

Total comments: 2

Patch Set 3 : Moving PK11_ValidateCurvePoint down in nss.def #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -0 lines)			Patch
M	lib/nss/nss.def	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	lib/pk11wrap/pk11akey.c	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	lib/pk11wrap/pk11pub.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/softoken/fipstokn.c	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	lib/softoken/pkcs11c.c	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
M	lib/util/pkcs11f.h	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

You need to fix nss.def, but the rest looks OK. Ask Bob for a second ...

9 years, 8 months ago (2016-02-03 03:54:53 UTC) #1

ttaubert

9 years, 8 months ago (2016-02-03 13:38:06 UTC) #2

https://codereview.appspot.com/281660043/diff/20001/lib/nss/nss.def
File lib/nss/nss.def (right):

https://codereview.appspot.com/281660043/diff/20001/lib/nss/nss.def#newcode120
lib/nss/nss.def:120: PK11_ValidateCurvePoint;
On 2016/02/03 03:54:53, mt wrote:
> This needs to go down the bottom in a section that matches the version it will
> appear in.

Done.

Expand All Messages | Collapse All Messages