Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(26)

Issue 28137: Refactor remote content fetching in php shindig (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
17 years, 1 month ago by panjie.pan
Modified:
16 years, 9 months ago
Reviewers:
panjie, chabotc1
CC:
shindig.remailer_gmail.com
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

1. remove dependency of GadgetContext when fetching remote content. 2. remove RemoteContentRequest->ignoreCache, use RemoteContentRequest->options->ignoreCache instead 3. remove dependency of SecurityToken in SigningFetcher, use $request->getToken() Now, we support multiFetch with mixed signed and normal requests: $request1 = new RemoteContentRequest('http://test.chabotc.com/signing.html'); $token = BasicSecurityToken::createFromValues('owner', 'viewer', 'app', 'domain', 'appUrl', '1', 'default'); $request1->setToken($token); $request1->setAuthType(RemoteContentRequest::$AUTH_SIGNED); $request2 = new RemoteContentRequest('http://test.chabotc.com/ok.html'); $requests = array($request1, $request2); $this->basicRemoteContent->multiFetch($requests);

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -133 lines) Patch
php/src/common/RemoteContent.php View 1 chunk +2 lines, -2 lines 0 comments Download
php/src/common/RemoteContentRequest.php View 4 chunks +9 lines, -14 lines 0 comments Download
php/src/common/sample/BasicRemoteContent.php View 4 chunks +38 lines, -16 lines 0 comments Download
php/src/gadgets/GadgetFactory.php View 5 chunks +10 lines, -6 lines 0 comments Download
php/src/gadgets/GadgetFeatureRegistry.php View 1 chunk +2 lines, -1 line 0 comments Download
php/src/gadgets/MakeRequestHandler.php View 1 chunk +2 lines, -1 line 0 comments Download
php/src/gadgets/ProxyBase.php View 1 chunk +1 line, -1 line 0 comments Download
php/src/gadgets/ProxyHandler.php View 1 chunk +2 lines, -1 line 0 comments Download
php/src/gadgets/SigningFetcher.php View 5 chunks +27 lines, -31 lines 0 comments Download
php/src/gadgets/SigningFetcherFactory.php View 1 chunk +4 lines, -5 lines 0 comments Download
php/src/gadgets/render/GadgetHrefRenderer.php View 2 chunks +2 lines, -1 line 0 comments Download
php/src/gadgets/sample/BasicGadgetSpecFactory.php View 1 chunk +4 lines, -1 line 0 comments Download
php/test/common/BasicRemoteContentTest.php View 11 chunks +44 lines, -53 lines 0 comments Download

Messages

Total messages: 1
panjie.pan
17 years, 1 month ago (2009-03-30 06:13:25 UTC) #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b