Issue 28051: Split sample bindings into SampleModule

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 28051: Split sample bindings into SampleModule (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 11 months ago by awiner

Modified:
16 years, 6 months ago

Reviewers:

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Description

This patch removes all @ImplementedBy or SocialApiGuiceModule references to sample code, and moves them into a SampleModule class (which is a subclass of SocialApiGuiceModule). The "samples" project, BTW, is broken with this patch - but equally broken as it was before the patch, instead of more broken.

Patch Set 1 #

Created: 16 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+92 lines, -130 lines)			Patch
java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/integration/JpaRestfulTestConfigHelper.java	View	2 chunks	+13 lines, -3 lines	0 comments	Download
java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/integration/JpaTestGuiceModule.java	View	5 chunks	+33 lines, -0 lines	0 comments	Download
java/server/src/main/webapp/WEB-INF/web.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
java/server/src/main/webapp/WEB-INF/web.full.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
java/server/src/main/webapp/WEB-INF/web.social.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
java/server/src/test/java/org/apache/shindig/server/JettyLauncher.java	View	3 chunks	+5 lines, -6 lines	0 comments	Download
java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndModule.java	View	1 chunk	+0 lines, -80 lines	0 comments	Download
java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndServer.java	View	3 chunks	+5 lines, -5 lines	0 comments	Download
java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java	View	4 chunks	+14 lines, -14 lines	0 comments	Download
java/social-api/src/main/java/org/apache/shindig/social/opensocial/oauth/OAuthDataStore.java	View	1 chunk	+1 line, -5 lines	0 comments	Download
java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/ActivityService.java	View	2 chunks	+0 lines, -4 lines	0 comments	Download
java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/AppDataService.java	View	2 chunks	+0 lines, -4 lines	0 comments	Download
java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/PersonService.java	View	1 chunk	+0 lines, -5 lines	0 comments	Download
java/social-api/src/test/java/org/apache/shindig/social/SocialApiTestsGuiceModule.java	View	2 chunks	+8 lines, -0 lines	0 comments	Download
java/social-api/src/test/java/org/apache/shindig/social/core/config/SocialApiGuiceModuleTest.java	View	2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Paul Lindner

16 years, 11 months ago (2009-03-16 23:22:34 UTC) #2

Reviewed. 

This all looks good.  At the end of the day the samples guice module can show
implementors how to get their code up and running.

Expand All Messages | Collapse All Messages