ticket:11985: Handle 'j' and 'J' in date time pattern skeletons.

source/test/intltest/dtfmttst.cpp

 /********************************************************************
  * COPYRIGHT:
  * Copyright (c) 1997-2015, International Business Machines
  * Corporation and others. All Rights Reserved.
  ********************************************************************/
 
 #include "unicode/utypes.h"
 
 #if !UCONFIG_NO_FORMATTING
 
@@ skipping 95 matching lines @@
 
     TESTCASE_AUTO(TestParseLeniencyAPIs);
     TESTCASE_AUTO(TestNumberFormatOverride);
     TESTCASE_AUTO(TestCreateInstanceForSkeleton);
     TESTCASE_AUTO(TestCreateInstanceForSkeletonDefault);
     TESTCASE_AUTO(TestCreateInstanceForSkeletonWithCalendar);
     TESTCASE_AUTO(TestDFSCreateForLocaleNonGregorianLocale);
     TESTCASE_AUTO(TestDFSCreateForLocaleWithCalendarInLocale);
     TESTCASE_AUTO(TestChangeCalendar);
 
+    TESTCASE_AUTO(TestPatternFromSkeleton);
+
     TESTCASE_AUTO_END;
 }
 
 void DateFormatTest::TestPatterns() {
     static const struct {
         const char *actualPattern;
         const char *expectedPattern;
         const char *localeID;
         const char *expectedLocalPattern;
     } EXPECTED[] = {
@@ skipping 4702 matching lines @@
     fmt->adoptCalendar(Calendar::createInstance(en_heb, status));
     if (!assertSuccess("", status)) {
         return;
     }
     UnicodeString result;
     FieldPosition pos(0);
     fmt->format(date(98, 5-1, 25), result, pos);
     assertEquals("format yMMMd", "Iyar 29, 5758", result);
 }
 
+void DateFormatTest::TestPatternFromSkeleton() {
+    static const struct {
+        const Locale& locale;
+        const char* const skeleton;
+        const char* const pattern;
+    } TESTDATA[] = {
+        // Ticket #11985
+        {Locale::getEnglish(), "jmm", "h:mm a"},

[roubert (google), 2015/11/17 21:34:17]

These test cases pass just like this before changeset 37860 and still pass
after, with this change set applied.

+        {Locale::getEnglish(), "Jmm", "hh:mm"},

[mark.edward.davis, 2015/11/18 12:15:29]

Make these jj and JJ to reduce dependency on changes in locale data.

[roubert (google), 2015/11/18 12:28:39]

Done.

+        {Locale::getGerman(), "jmm", "HH:mm"},
+        {Locale::getGerman(), "Jmm", "HH:mm"},
+    };
+
+    for (size_t i = 0; i < sizeof TESTDATA / sizeof *TESTDATA; i++) {
+        UErrorCode status = U_ZERO_ERROR;
+        LocalPointer<DateFormat> fmt(
+                DateFormat::createInstanceForSkeleton(
+                        TESTDATA[i].skeleton, TESTDATA[i].locale, status));
+        if (!assertSuccess("createInstanceForSkeleton", status)) {
+            return;
+        }
+        UnicodeString pattern;
+        static_cast<const SimpleDateFormat*>(fmt.getAlias())->toPattern(pattern);
+        assertEquals("Format pattern", TESTDATA[i].pattern, pattern);
+    }
+}
+
 
 #endif /* #if !UCONFIG_NO_FORMATTING */
 
 //eof