Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(87)

Issue 279140043: Doc: NR - Issue 4677 - input.itely: Various improvements (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 9 months ago by pkx166h
Modified:
2 years, 6 months ago
Reviewers:
HoangMinh, dak, mail, fede, fedelogy, simon.albrecht
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

A variety of nitpicks and improvements reported by Federico Bruni Updated information and included a new @lilypond example for \KeepWithTag. Some spelling corrections and some simple rewording of a few paragraphs for clarity (deleted repeated words, removed personal pronouns etc.). Moved a comment (@c) outside of an @example so as to not cause confusion to readers.

Patch Set 1 #

Patch Set 2 : Additional corrections and updates by Federico B #

Patch Set 3 : Fix Typo that breaks make doc. #

Total comments: 2

Patch Set 4 : With Federico B's comments and corrections. #

Total comments: 7

Patch Set 5 : More for Federico B #

Patch Set 6 : rebase with current master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -39 lines) Patch
M Documentation/notation/input.itely View 1 2 3 4 5 10 chunks +74 lines, -39 lines 0 comments Download

Messages

Total messages: 20
pkx166h
Additional corrections and updates by Federico B
3 years, 7 months ago (2016-02-18 10:45:20 UTC) #1
pkx166h
Fix Typo that breaks make doc.
3 years, 7 months ago (2016-02-18 11:38:09 UTC) #2
fedelogy
LGTM, except for one paragraph. Thanks https://codereview.appspot.com/279140043/diff/40001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/279140043/diff/40001/Documentation/notation/input.itely#newcode2313 Documentation/notation/input.itely:2313: Sorry, I'm still ...
3 years, 7 months ago (2016-02-18 22:51:46 UTC) #3
pkx166h
With Federico B's comments and corrections.
3 years, 7 months ago (2016-02-21 10:43:35 UTC) #4
pkx166h
Thanks Federico - see inline for my replies. https://codereview.appspot.com/279140043/diff/40001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/279140043/diff/40001/Documentation/notation/input.itely#newcode2313 Documentation/notation/input.itely:2313: On ...
3 years, 7 months ago (2016-02-21 10:44:37 UTC) #5
simon.albrecht
https://codereview.appspot.com/279140043/diff/60001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/279140043/diff/60001/Documentation/notation/input.itely#newcode2319 Documentation/notation/input.itely:2319: \tag #'D { d4 d d d } I’d ...
3 years, 7 months ago (2016-02-21 12:17:12 UTC) #6
fede_inventati.org
Il giorno dom 21 feb 2016 alle 11:44, pkx166h@gmail.com ha scritto: > Thanks Federico - ...
3 years, 6 months ago (2016-02-22 12:55:12 UTC) #7
dak
https://codereview.appspot.com/279140043/diff/60001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/279140043/diff/60001/Documentation/notation/input.itely#newcode2323 Documentation/notation/input.itely:2323: \keepWithTag #'(A B) On 2016/02/21 12:17:12, simon.albrecht wrote: > ...
3 years, 6 months ago (2016-02-22 17:05:13 UTC) #8
pkx166h
https://codereview.appspot.com/279140043/diff/60001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/279140043/diff/60001/Documentation/notation/input.itely#newcode2319 Documentation/notation/input.itely:2319: \tag #'D { d4 d d d } On ...
3 years, 6 months ago (2016-02-24 06:54:43 UTC) #9
pkx166h
@David or Federico Could one or you (or some other kind soul) explain the comment ...
3 years, 6 months ago (2016-02-27 11:22:56 UTC) #10
dak
On 2016/02/27 11:22:56, pkx166h wrote: > @David or Federico > > Could one or you ...
3 years, 6 months ago (2016-02-27 12:10:57 UTC) #11
pkx166h
On 2016/02/27 12:10:57, dak wrote: > On 2016/02/27 11:22:56, pkx166h wrote: > > @David or ...
3 years, 6 months ago (2016-02-27 12:21:48 UTC) #12
mail_philholmes.net
----- Original Message ----- From: <dak@gnu.org> To: <pkx166h@gmail.com>; <fedelogy@gmail.com>; <simon.albrecht@mail.de>; <fede@inventati.org> Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org> Sent: ...
3 years, 6 months ago (2016-02-27 12:30:56 UTC) #13
dak
On 2016/02/27 12:30:56, mail_philholmes.net wrote: > \tag #'Ex1 > \tag Ex > > are both ...
3 years, 6 months ago (2016-02-27 12:58:44 UTC) #14
HoangMinh
On 2016/02/27 12:58:44, dak wrote: > On 2016/02/27 12:30:56, http://mail_philholmes.net wrote: > > > \tag ...
3 years, 6 months ago (2016-02-28 05:39:41 UTC) #15
pkx166h
On 2016/02/22 12:55:12, fede_inventati.org wrote: > Il giorno dom 21 feb 2016 alle 11:44, mailto:pkx166h@gmail.com ...
3 years, 6 months ago (2016-03-01 20:08:56 UTC) #16
pkx166h
More for Federico B
3 years, 6 months ago (2016-03-01 20:09:58 UTC) #17
fedelogy
On 2016/03/01 20:09:58, pkx166h wrote: > More for Federico B LGTM, thanks
3 years, 6 months ago (2016-03-03 11:53:51 UTC) #18
pkx166h
rebase with current master
3 years, 4 months ago (2016-04-23 08:56:51 UTC) #19
pkx166h
2 years, 6 months ago (2017-03-12 18:35:00 UTC) #20
author James Lowe pkx166h@gmail.com
Thu, 18 Feb 2016 10:43:09 +0000 (10:43 +0000)
committer James Lowe pkx166h@gmail.com
Thu, 28 Apr 2016 06:41:48 +0000 (07:41 +0100)
commit c5847c9329abba798fb15bb336c7247ab149660b
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b