|
This is an alternative implementation of the feature in issue:
https://codereview.appspot.com/277230044/
The basic difference is as follows. In this implementation, care is taken to avoid any need to touch NetDevice types that do not implement Class of Service handling. Instead, the IP layer (Ipv4Interface) will query the device for a special ClassOfServiceInterface object. This has been aggregated to WifiNetDevice but no other devices. If the GetObject<> () succeeds, then an additional Send() method is exposed, with an additional class of service parameter.
This version follows the ns-3 pattern of using object aggregation (querying for an aggregated interface) to avoid the need to touch all derived classes. However, it makes it more complicated in the IP code to look for this interface rather than use the existing Send().
Total comments: 3
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+775 lines, -15 lines) |
Patch |
|
A |
examples/wireless/wifi-qos.cc
|
View
|
|
1 chunk |
+184 lines, -0 lines |
1 comment
|
Download
|
|
M |
examples/wireless/wscript
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/applications/model/onoff-application.h
|
View
|
|
2 chunks |
+17 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/applications/model/onoff-application.cc
|
View
|
|
4 chunks |
+28 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/applications/model/udp-client.h
|
View
|
|
1 chunk |
+20 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/applications/model/udp-client.cc
|
View
|
|
4 chunks |
+29 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/internet/model/ipv4-header.h
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/internet/model/ipv4-header.cc
|
View
|
|
1 chunk |
+41 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/internet/model/ipv4-interface.h
|
View
|
|
2 chunks |
+3 lines, -1 line |
1 comment
|
Download
|
|
M |
src/internet/model/ipv4-interface.cc
|
View
|
|
3 chunks |
+64 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/internet/model/ipv4-l3-protocol.cc
|
View
|
|
8 chunks |
+11 lines, -6 lines |
0 comments
|
Download
|
|
M |
src/network/model/socket.h
|
View
|
|
1 chunk |
+49 lines, -1 line |
1 comment
|
Download
|
|
A |
src/network/utils/class-of-service-interface.h
|
View
|
|
1 chunk |
+96 lines, -0 lines |
0 comments
|
Download
|
|
A |
src/network/utils/class-of-service-interface.cc
|
View
|
|
1 chunk |
+44 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/network/wscript
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/wifi/helper/wifi-helper.cc
|
View
|
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
|
A |
src/wifi/model/wifi-class-of-service-interface.h
|
View
|
|
1 chunk |
+84 lines, -0 lines |
0 comments
|
Download
|
|
A |
src/wifi/model/wifi-class-of-service-interface.cc
|
View
|
|
1 chunk |
+88 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/wifi/wscript
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
Total messages: 4
|