Notify objects when container configurations change

Some objects are initialized at start-up time with the list of containers. These have to update their data when the container configuration is changed. This patch enables just that.

[zhoresh, 2010-10-28 01:06:26]

lgtm

http://codereview.appspot.com/2773041/diff/1/java/gadgets/src/main/java/org/a...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java
(right):

http://codereview.appspot.com/2773041/diff/1/java/gadgets/src/main/java/org/a...
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java:75:
config.addConfigObserver(this);
This can be gated by ldEnabled

[johnfargo, 2010-10-28 19:27:28]

http://codereview.appspot.com/2773041/diff/1/java/common/src/main/java/org/ap...
File
java/common/src/main/java/org/apache/shindig/config/BasicContainerConfig.java
(right):

http://codereview.appspot.com/2773041/diff/1/java/common/src/main/java/org/ap...
java/common/src/main/java/org/apache/shindig/config/BasicContainerConfig.java:112:
observers.add(observer);
upon adding a new config observer, we could opt to simply call:
observer.containersChanged(this, config.keySet(), <empty collection or null>);

http://codereview.appspot.com/2773041/diff/1/java/common/src/main/java/org/ap...
File java/common/src/main/java/org/apache/shindig/config/ContainerConfig.java
(right):

http://codereview.appspot.com/2773041/diff/1/java/common/src/main/java/org/ap...
java/common/src/main/java/org/apache/shindig/config/ContainerConfig.java:41: *
(${foo.bar}).
while we're cleaning up comments, we could update this indicating the classes
that implement the default impls

http://codereview.appspot.com/2773041/diff/1/java/common/src/main/java/org/ap...
java/common/src/main/java/org/apache/shindig/config/ContainerConfig.java:169: * 
      changed.
nit: w/ 100-char width this could be on one line.

http://codereview.appspot.com/2773041/diff/1/java/common/src/main/java/org/ap...
java/common/src/main/java/org/apache/shindig/config/ContainerConfig.java:171: * 
      modified.
same

[jtarrio, 2010-10-28 23:23:53]

http://codereview.appspot.com/2773041/diff/1/java/common/src/main/java/org/ap...
File
java/common/src/main/java/org/apache/shindig/config/BasicContainerConfig.java
(right):

http://codereview.appspot.com/2773041/diff/1/java/common/src/main/java/org/ap...
java/common/src/main/java/org/apache/shindig/config/BasicContainerConfig.java:112:
observers.add(observer);
On 2010/10/28 19:27:28, johnfargo wrote:
> upon adding a new config observer, we could opt to simply call:
> observer.containersChanged(this, config.keySet(), <empty collection or null>);

I've added a boolean notifyNow parameter, by which, when true, a notification is
sent immediately for the current configuration.

http://codereview.appspot.com/2773041/diff/1/java/common/src/main/java/org/ap...
File java/common/src/main/java/org/apache/shindig/config/ContainerConfig.java
(right):

http://codereview.appspot.com/2773041/diff/1/java/common/src/main/java/org/ap...
java/common/src/main/java/org/apache/shindig/config/ContainerConfig.java:41: *
(${foo.bar}).
On 2010/10/28 19:27:28, johnfargo wrote:
> while we're cleaning up comments, we could update this indicating the classes
> that implement the default impls

Done.

http://codereview.appspot.com/2773041/diff/1/java/common/src/main/java/org/ap...
java/common/src/main/java/org/apache/shindig/config/ContainerConfig.java:169: * 
      changed.
On 2010/10/28 19:27:28, johnfargo wrote:
> nit: w/ 100-char width this could be on one line.

Yeah, but it looks like my Eclipse sets Javadocs to 80 columns (and I tend to
agree :)).

http://codereview.appspot.com/2773041/diff/1/java/gadgets/src/main/java/org/a...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java
(right):

http://codereview.appspot.com/2773041/diff/1/java/gadgets/src/main/java/org/a...
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java:75:
config.addConfigObserver(this);
On 2010/10/28 01:06:26, zhoresh wrote:
> This can be gated by ldEnabled

Done.

[jtarrio, 2010-10-28 23:24:14]

After some changes

[jtarrio, 2010-10-29 20:05:13]

With change after svn update

[johnfargo, 2010-10-29 20:14:06]

Thanks Jacobo, committed as r1028896.

On 2010/10/28 23:24:14, jtarrio wrote:
> After some changes