Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(76)

Issue 2770041: Refactoring StyleTagProxyEmbeddedUrlsRewriter to use DefaultConfig instead (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 2 months ago by gagan.goku
Modified:
15 years, 1 month ago
Reviewers:
dev, Kuntal Loya
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Currently StyleTagProxyEmbeddedUrlsRewriter uses the featureConfigFactory to fetch the gadget spec. However, since accel html web pages don't really have a gadget (In AccelHandler.getProxyUri(), we create a dummy gadget object based on the original HttpRequest object and set its url to the html page being rendered), feature config factory ends up fetching the content of html web page again, rewrites it and falls back to default config since its not able to parse it as gadget xml. Hence this change allows us to directly use default config for the StyleTagProxyEmbeddedUrlsRewriter (which is an accel specific rewriter).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/StyleTagProxyEmbeddedUrlsRewriter.java View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6
anupama.dutta
Code change looks good. Could you update the change description to make the purpose of ...
15 years, 2 months ago (2010-10-29 11:21:31 UTC) #1
anupama.dutta
On 2010/10/29 11:21:31, anupama.dutta wrote: > Code change looks good. Could you update the change ...
15 years, 1 month ago (2010-11-09 03:36:55 UTC) #2
gagan.goku
Sorry for the delay. Changed desc. please take anoher look.
15 years, 1 month ago (2010-11-09 10:07:15 UTC) #3
anupama.dutta
LGTM. Please send out to dev@ for further review.
15 years, 1 month ago (2010-11-09 11:01:48 UTC) #4
Kuntal Loya
lgtm
15 years, 1 month ago (2010-11-11 07:07:29 UTC) #5
gagan.goku
15 years, 1 month ago (2010-11-11 11:56:55 UTC) #6
On 2010/11/11 07:07:29, Kuntal Loya wrote:
> lgtm

Build looks good.
Committed as r1033903.
Thanks for the reviews.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b