code review 2763041: use copy

src/pkg/debug/macho/file.go

 // Copyright 2009 The Go Authors.  All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 // Package macho implements access to Mach-O object files, as defined by
 // http://developer.apple.com/mac/library/documentation/DeveloperTools/Conceptual/MachORuntime/Reference/reference.html.
 package macho
 
 // High level access to low level data structures.
 
@@ skipping 288 matching lines @@
                 }
         }
         return f, nil
 }
 
 func (f *File) pushSection(sh *Section, r io.ReaderAt) {
         n := len(f.Sections)
         if n >= cap(f.Sections) {
                 m := (n + 1) * 2
                 new := make([]*Section, n, m)
-                for i, sh := range f.Sections {
-                        new[i] = sh
-                }
+                copy(new, f.Sections)
                 f.Sections = new
         }
         f.Sections = f.Sections[0 : n+1]
         f.Sections[n] = sh
         sh.sr = io.NewSectionReader(r, int64(sh.Offset), int64(sh.Size))
         sh.ReaderAt = sh.sr
 }
 
 func cstring(b []byte) string {
         var i int
@@ skipping 39 matching lines @@
                 b, err := s.Data()
                 if err != nil && uint64(len(b)) < s.Size {
                         return nil, err
                 }
                 dat[i] = b
         }
 
         abbrev, info, str := dat[0], dat[1], dat[2]
         return dwarf.New(abbrev, nil, nil, info, nil, nil, nil, str)
 }