Issue 276300043: Bug 1229787 - Remove SSLv2 support for SSL coverage and stress tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 276300043: Bug 1229787 - Remove SSLv2 support for SSL coverage and stress tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by ttaubert

Modified:
10 years, 3 months ago

Reviewers:
ekr, mt, ekr-rietveld

Visibility:
Public.

More Reviews

Description

Bug 1229787 - Remove SSLv2 support for SSL coverage and stress tests

Patch Set 2 : Reverting API changes #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -194 lines)			Patch
M	cmd/lib/secutil.c	View	1	5 chunks	+14 lines, -26 lines	2 comments	Download
M	cmd/selfserv/selfserv.c	View	1	9 chunks	+6 lines, -30 lines	0 comments	Download
M	cmd/strsclnt/strsclnt.c	View	1	10 chunks	+16 lines, -54 lines	0 comments	Download
M	cmd/tstclnt/tstclnt.c	View	1	9 chunks	+7 lines, -38 lines	0 comments	Download
M	tests/ssl/ssl.sh	View		5 chunks	+8 lines, -30 lines	0 comments	Download
M	tests/ssl/sslcov.txt	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	tests/ssl/sslstress.txt	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

You'll need to avoid changing public APIs. I think that even if the API is ...

10 years, 5 months ago (2015-12-03 06:45:49 UTC) #1

ttaubert

On 2015/12/03 06:45:49, mt wrote: > We can't change the public API like this. We'll ...

10 years, 5 months ago (2015-12-03 09:20:28 UTC) #2

LGTM https://codereview.appspot.com/276300043/diff/20001/cmd/lib/secutil.c File cmd/lib/secutil.c (right): https://codereview.appspot.com/276300043/diff/20001/cmd/lib/secutil.c#newcode3728 cmd/lib/secutil.c:3728: if (!input || !vrange) { Please reject attempts ...

10 years, 5 months ago (2015-12-05 10:17:09 UTC) #3

ttaubert

10 years, 3 months ago (2016-01-27 14:09:03 UTC) #4

https://codereview.appspot.com/276300043/diff/20001/cmd/lib/secutil.c
File cmd/lib/secutil.c (right):

https://codereview.appspot.com/276300043/diff/20001/cmd/lib/secutil.c#newcode...
cmd/lib/secutil.c:3728: if (!input || !vrange) {
On 2015/12/05 10:17:08, mt wrote:
> Please reject attempts to set defaultEnableSSL2 as well.

Done.

Expand All Messages | Collapse All Messages