Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1156)

Issue 2757042: code review 2757042: gc: implement append (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by rsc
Modified:
11 years, 3 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

gc: implement append

Patch Set 1 #

Patch Set 2 : code review 2757042: gc: implement append #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -14 lines) Patch
M src/cmd/gc/builtin.c.boot View 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/gc/go.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/cmd/gc/lex.c View 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/print.c View 2 chunks +2 lines, -0 lines 0 comments Download
M src/cmd/gc/runtime.go View 1 chunk +4 lines, -0 lines 0 comments Download
M src/cmd/gc/subr.c View 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/typecheck.c View 2 chunks +35 lines, -1 line 0 comments Download
M src/cmd/gc/walk.c View 3 chunks +46 lines, -0 lines 0 comments Download
M src/pkg/runtime/slice.c View 1 2 chunks +77 lines, -13 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
11 years, 3 months ago (2010-10-28 00:56:30 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=6f22a696557f *** gc: implement append R=ken2 CC=golang-dev http://codereview.appspot.com/2757042
11 years, 3 months ago (2010-10-28 00:56:34 UTC) #2
ken3
11 years, 3 months ago (2010-10-28 04:38:38 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b