Issue 275650043: Bug 1230084 - Remove SSLv2/3 auto-detection code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 275650043: Bug 1230084 - Remove SSLv2/3 auto-detection code (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by ttaubert

Modified:
10 years, 1 month ago

Reviewers:
ekr, mt, ekr-rietveld

Visibility:
Public.

More Reviews

Description

Bug 1230084 - Remove SSLv2/3 auto-detection code

Patch Set 1 #

Total comments: 4

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -3615 lines)			Patch
M	lib/ssl/notes.txt	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	lib/ssl/ssl3con.c	View	8 chunks	+1 line, -224 lines	2 comments	Download
M	lib/ssl/sslauth.c	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	lib/ssl/sslcon.c	View	9 chunks	+16 lines, -2945 lines	0 comments	Download
M	lib/ssl/sslgathr.c	View	2 chunks	+0 lines, -389 lines	2 comments	Download
M	lib/ssl/sslimpl.h	View	6 chunks	+1 line, -14 lines	0 comments	Download
M	lib/ssl/sslsecur.c	View	4 chunks	+4 lines, -31 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

I like this. Lots of red. The sslgathr.c suggestion you can act on later; the ...

10 years, 3 months ago (2015-12-05 09:15:26 UTC) #1

ttaubert

10 years, 1 month ago (2016-01-27 15:01:41 UTC) #2

https://codereview.appspot.com/275650043/diff/1/lib/ssl/ssl3con.c
File lib/ssl/ssl3con.c (left):

https://codereview.appspot.com/275650043/diff/1/lib/ssl/ssl3con.c#oldcode7906
lib/ssl/ssl3con.c:7906: * call ssl2_HandleMessage.
On 2015/12/05 09:15:26, mt wrote:
> I don't see any changes in ssl_Do1stHandshake.  Can you explain to me why
> removing this is safe?

ssl2_HandleMessage() doesn't exist anymore and we don't need to zero the
pointers anymore when upgrading from a v2 client hello.

https://codereview.appspot.com/275650043/diff/1/lib/ssl/sslgathr.c
File lib/ssl/sslgathr.c (right):

https://codereview.appspot.com/275650043/diff/1/lib/ssl/sslgathr.c#newcode2
lib/ssl/sslgathr.c:2: * Gather (Read) entire SSL2 records from socket into
buffer.
On 2015/12/05 09:15:26, mt wrote:
> This file might not be big enough now to justify its continued existence.

Will merge everything into sslgathr.c

Expand All Messages | Collapse All Messages